poudriere.conf is handed to sysrc(8), including the jail, tree, and
set overlays poudriere(8) consults. make, src, and src-env are
sub-targets over the matching make(1) files under poudriere.d. -l
and -L list one path per line; -L includes overlays that do not exist
yet. A bare -- ends the sub-target so the next word is a variable.
Bump sysconf(8) to 2.2.
Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 77226 Build 74109: arc lint + arc unit
Event Timeline
The value-add here in adding a poudriere target is essentially because poudriere has a semi-complicated overlay system of configuration. For example, there is not one global config but two (a configuration directive in /usr/local/etc/poudriere.conf can be overridden by the file /usr/local/etc/poudriere.d/poudriere.conf) and thus it's important to have a tool that can both dump config directives as poudriere sees them (overlaying poudriere.d config on top of the standard config, then dumping the results) with, e.g., sysconf p -a as well as a tool that can modify the setting where it will have an effect. It removes the headache of having to check which config holds the final word. For example, if you have USE_TMPFS=yes in /usr/local/etc/poudriere.conf but then you have USE_TMPFS=no in /usr/local/etc/poudriere.d/poudriere.conf then you could be mistaken to edit the former (as the latter will still override the value you set). In such an example, sysconf p -av will show you not only every setting but where it is set.
To make things worse, as-documented in poudriere(8), there is a combinatorial explosion of possible config file overlays that occurs when we bring in jailname, portname, and setname. Albeit a small explosion, it's still C(2,3) which is 3 possible combinations for overlays:
Using the -L option of sysconf to enumerate all the possible config files, we can see just how bad it can be:
$ sysconf p -L --jail='<jailname>' --set='<setname>' --tree='<treename>' /usr/local/etc/poudriere.conf /usr/local/etc/poudriere.d/poudriere.conf /usr/local/etc/poudriere.d/<setname>-poudriere.conf /usr/local/etc/poudriere.d/<treename>-poudriere.conf /usr/local/etc/poudriere.d/<jailname>-poudriere.conf /usr/local/etc/poudriere.d/<treename>-<setname>-poudriere.conf /usr/local/etc/poudriere.d/<jailname>-<treename>-poudriere.conf /usr/local/etc/poudriere.d/<jailname>-<setname>-poudriere.conf /usr/local/etc/poudriere.d/<jailname>-<treename>-<setname>-poudriere.conf
That's 9 possible configuration files where directives can live. So for a given directive such as USE_TMPFS, the value can come from any one of 9 possible files depending on the combination of jail, set, and/or tree. These paths are documented in poudriere(8) and sysconf(8) as a companion actually makes wrangling this quite manageable.
That's the nature of the whole thing of why adding a poudriere target is advantageous.
Thank you very much for the review.