Page MenuHomeFreeBSD
Differential D59071

sound: Embed mixer cdev in snd_mixer
ClosedPublic
Actions

Authored by christos on Aug 21 2026, 12:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 5, 8:56 AM
Unknown Object (File)
Sun, Oct 4, 2:37 PM
Unknown Object (File)
Sun, Oct 4, 2:34 PM
Unknown Object (File)
Sat, Oct 3, 8:51 PM
Unknown Object (File)
Sat, Oct 3, 1:20 PM
Unknown Object (File)
Sat, Oct 3, 1:33 AM
Unknown Object (File)
Sat, Oct 3, 12:39 AM
Unknown Object (File)
Fri, Oct 2, 11:37 AM
View All 67 Files
Subscribers
imp

Details

Reviewers
markj
emaste
kib
Commits
rGa614c07ad452: sound: Embed mixer cdev in snd_mixer
Summary

The mixer cdev belongs to the mixer, not to the PCM device, so move it
from snddev_info->mixer_dev into a new snd_mixer->cdev field. snd_mixer
itself is now included in snddev_info.

Also add a MIXER_REGISTERED() macro similar to PCM_REGISTERED().

Sponsored by: The FreeBSD Foundation
MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Aug 21 2026, 12:42 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 21 2026, 12:42 PM
Harbormaster completed remote builds in B75936: Diff 184637.Aug 21 2026, 12:42 PM
christos requested review of this revision.Aug 21 2026, 12:42 PM
christos added a child revision: D59073: sound: Defer macio codec volume writes to a task.Aug 21 2026, 12:44 PM
christos added a parent revision: D59070: sound: Simplify how snd_mixer is fetched and how the cdev is created.
kib added inline comments.Aug 22 2026, 6:18 AM
sys/dev/sound/pcm/mixer.c
719

Do you need to clear m->cdev? What is the lifetime for struct snd_mixer?

christos added inline comments.Aug 22 2026, 11:20 AM
sys/dev/sound/pcm/mixer.c
719

snd_mixer gets freed in this function here, which is called by pcm_unregister() during detach. I think we should be fine and not NULL it.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Sep 18, 6:19 PM
Closed by commit rGa614c07ad452: sound: Embed mixer cdev in snd_mixer (authored by christos). · Explain Why
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGa614c07ad452: sound: Embed mixer cdev in snd_mixer.

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pci/
2 lines
pcm/
16 lines
3 lines
37 lines
1 line

Diff 187125

View Options

sys/dev/sound/pci/es137x.c

Loading...
View Options

sys/dev/sound/pcm/dsp.c

Loading...
View Options

sys/dev/sound/pcm/mixer.h

Loading...
View Options

sys/dev/sound/pcm/mixer.c

Loading...
View Options

sys/dev/sound/pcm/sound.h

Loading...