Differential D59811

Mk/bsd.port.mk: Drop the strip parameter from PATCHFILES passed to do-fetch.sh
ClosedPublic
Actions

Authored by 0mp on Fri, Sep 18, 11:42 AM.

Tags

Referenced Files

	F173611666: D59811.diff
	Sun, Sep 27, 4:33 AM

	F173592394: D59811.diff
	Sun, Sep 27, 1:27 AM

	Unknown Object (File)
	Sat, Sep 26, 3:12 PM

	Unknown Object (File)
	Sat, Sep 26, 5:12 AM

	Unknown Object (File)
	Sat, Sep 26, 2:03 AM

	Unknown Object (File)
	Sat, Sep 26, 1:00 AM

	Unknown Object (File)
	Sat, Sep 26, 12:23 AM

	Unknown Object (File)
	Fri, Sep 25, 8:30 PM

View All 30 Files

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

R11:20f33287b059: Mk/bsd.port.mk: Drop the strip parameter from PATCHFILES passed to do-fetch.sh

Summary

After recent changes to handling of do-fetch.sh in bsd.port.mk, the
strip parameters (e.g., ":-p1") are no longer dropped before do-fetch.sh
receives patch files.

As a result, a strip parameter of a patch file might be interpreted as a
group instead and get prepended to the patch file, resulting in warnings
like:

$ make makesum
===>  License MIT accepted by the user
=> e3efbb5923f638b38087a3f616906d9d4fdaf6f2.patch doesn't seem to exist in /var/cache/distfiles.
=> Attempting to fetch p1e3efbb5923f638b38087a3f616906d9d4fdaf6f2.patch
fetch: p1e3efbb5923f638b38087a3f616906d9d4fdaf6f2.patch: No such file or directory

Fixes: 076687302bff Mk: fix checksum/fetch/makesum with large distfiles set
Sponsored by: fme AG

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77057
Build 73940: arc lint + arc unit

Event Timeline

0mp requested review of this revision.Fri, Sep 18, 11:42 AM

0mp created this revision.

Harbormaster completed remote builds in B77056: Diff 187083.Fri, Sep 18, 11:42 AM

0mp added reviewers: portmgr, mat.Fri, Sep 18, 11:42 AM

0mp added a project: portmgr.

s/:p/:-p/

Harbormaster completed remote builds in B77057: Diff 187084.Fri, Sep 18, 11:57 AM

Thank you.

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Sep 18, 12:08 PM

Closed by commit R11:20f33287b059: Mk/bsd.port.mk: Drop the strip parameter from PATCHFILES passed to do-fetch.sh (authored by 0mp). · Explain Why

This revision was automatically updated to reflect the committed changes.

0mp added a commit: R11:20f33287b059: Mk/bsd.port.mk: Drop the strip parameter from PATCHFILES passed to do-fetch.sh.

Revision Contents
Changeset List

Path

Size

Mk/

2 lines

Diff 187084

Mk/bsd.port.mk

Loading...