LinuxKPI: implement __UNIQUE_ID() macro
ClosedPublic
Actions

Authored by wulf on Wed, Sep 16, 5:38 PM.

Details

Reviewers

Commits

rG8b05d84be9e2: LinuxKPI: implement __UNIQUE_ID() macro

Summary

Requred by drm-kmod v6.12.103

Obtained from: OpenBSD

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76983
Build 73866: arc lint + arc unit

wulf requested review of this revision.Wed, Sep 16, 5:38 PM

emaste added inline comments.

sys/compat/linuxkpi/common/include/linux/compiler.h
100–102	Do we have any compilers that don't provide `__COUNTER__`? We can perhaps just omit this.

This revision is now accepted and ready to land.Wed, Sep 16, 5:45 PM

bz requested changes to this revision.Wed, Sep 16, 7:37 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/compiler.h
100–102	We are using `__COUNTER__` elsewhere in LinuxKPI (and sys/sys) unconditionally. So this should really go away.
104	Linux documents the format as: `__UNIQUE_ID_<name>_<__COUNTER__>`

This revision now requires changes to proceed.Wed, Sep 16, 7:37 PM

sys/compat/linuxkpi/common/include/linux/compiler.h
104	I was thinking it doesn't really matter, but I suppose it is worth putting it into some `__` namespace to avoid possible conflict with a real symbol.