video(4): add extended controls and remaining V4L2 compat symbols
ClosedPublic
Actions

Authored by seuros on Mon, Sep 7, 8:09 PM.

Details

Reviewers

Commits

Summary

Add the extended control interface

Values match the reference ABI; the new struct layouts are pinned
with static assertions.

Reported by: thierry

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 76921
Build 73804: arc lint + arc unit

seuros requested review of this revision.Mon, Sep 7, 8:09 PM

approved; @thierry are these ok for you? what would you like to test build them with to make sure they're all ok now?

This revision is now accepted and ready to land.Wed, Sep 9, 7:21 PM

I don't see why this requires a __FreeBSD_version bump. What for?

seuros removed a reviewer: Jails.

Hello,
I'm attending EuroBSDCon ATM and cannot test it: could you please wait until next week?

In D59496#1366427, @arrowd wrote:

I don't see why this requires a __FreeBSD_version bump. What for?

Because the port won't build between OSVERSION 160020 and this one.

anything else before landing this?

The 32 comment would be a "nice to fix" pre-commit.

sys/sys/videoio.h
375	Why 32? Is there a constant somewhere that could be used/defined in place of this value?

sys/sys/videoio.h
375	This is the structure that is upstream, i don't want to diverge. The old code used 32 and the ports expect it.

sys/sys/videoio.h
375	This is the structure that is upstream, i don't want to diverge. The old code used 32 and the ports expect it. Could you please add a short (one line) comment noting that?

Its fine for me, thanks!

(Sorry for the delay: I have been attending EuroBSDCon, and was not able to check it from Brussels)

sys/sys/videoio.h
375	Sure thing ! I will do that in the followup diff. I'm trying to implement the cropping instead of leaving the stub. That ok for you ? I dont like to reset the approval count. (but i can do it)