Page MenuHomeFreeBSD
Differential D58845

LinuxKPI: Add cpufreq_quick_get_max to LinuxKPI for amdkfd support
Needs ReviewPublic
Actions

Authored by siri_racha.ca on Aug 14 2026, 4:41 PM.
Tags
Referenced Files
Unknown Object (File)
Tue, Sep 22, 1:10 PM
Unknown Object (File)
Mon, Sep 21, 2:20 PM
Unknown Object (File)
Sun, Sep 20, 9:03 PM
Unknown Object (File)
Sun, Sep 20, 9:26 AM
Unknown Object (File)
Sun, Sep 20, 1:07 AM
Unknown Object (File)
Fri, Sep 18, 12:34 AM
Unknown Object (File)
Tue, Sep 15, 9:01 AM
Unknown Object (File)
Mon, Sep 14, 7:51 PM
View All 37 Files
Subscribers
bz
dumbbell
emaste
imp

Details

Reviewers
None
Group Reviewers
linuxkpi
Summary

Adding the cpufreq_quick_get_max function for amdkfd support as it's called by
kfd_topology.c

Sponsored By: The FreeBSD Foundation

Test Plan

Builds when applied to CURRENT

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

siri_racha.ca created this revision.Aug 14 2026, 4:41 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptAug 14 2026, 4:41 PM
siri_racha.ca requested review of this revision.Aug 14 2026, 4:41 PM
siri_racha.ca edited the summary of this revision. (Show Details)
siri_racha.ca added parent revisions: D58228: LinuxKPI: Add tgid to task_struct under sched.h, D58222: LinuxKPI: Add in_compat_syscall for amdkfd support, D58207: LinuxKPI: Adding functions to mmu_notifier.h to satisify requirements to compile kfd_process.c in amdkfd driver, D58076: LinuxKPI: Add compat_ptr_ioctl, D58075: LinuxKPI: Added jiffies64_to_msecs for amdkfd compatibility., D57465: LinuxKPI: Create `linux/util_macros.h`.Tue, Aug 25, 7:02 PM
siri_racha.ca removed parent revisions: D57465: LinuxKPI: Create `linux/util_macros.h`, D58075: LinuxKPI: Added jiffies64_to_msecs for amdkfd compatibility., D58076: LinuxKPI: Add compat_ptr_ioctl, D58207: LinuxKPI: Adding functions to mmu_notifier.h to satisify requirements to compile kfd_process.c in amdkfd driver, D58222: LinuxKPI: Add in_compat_syscall for amdkfd support, D58228: LinuxKPI: Add tgid to task_struct under sched.h.Thu, Sep 3, 8:11 PM
siri_racha.ca added a child revision: D58222: LinuxKPI: Add in_compat_syscall for amdkfd support.Fri, Sep 11, 4:30 AM
siri_racha.ca edited the summary of this revision. (Show Details)Fri, Sep 11, 9:51 PM
siri_racha.ca updated this revision to Diff 186491.Fri, Sep 11, 10:03 PM
siri_racha.ca edited the test plan for this revision. (Show Details)
emaste added inline comments.Sun, Sep 13, 8:42 AM
sys/compat/linuxkpi/common/include/linux/cpufreq.h
26–27

Linux returns 0 if no result, it's probably sensible to do the same here. On platforms of interest in this context the sysctl is going to be successful.

siri_racha.ca updated this revision to Diff 186642.Mon, Sep 14, 4:05 AM

Switched fallback to 0 GHz

siri_racha.ca marked an inline comment as done.Mon, Sep 14, 4:54 AM
siri_racha.ca added inline comments.
sys/compat/linuxkpi/common/include/linux/cpufreq.h
26–27

Sounds good, I thought when I first read the Linux impl it returned 1 Ghz, checked again and it's 0.
My bad

bz added a subscriber: bz.Mon, Sep 14, 6:59 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/linux/cpufreq.h
7

Please do not use LINUX but LINUXKPI prefixes; check some other files for samples (LINUX is the historic name we try to get rid off)

23

No block needed here.

dumbbell added a subscriber: dumbbell.Mon, Sep 14, 7:54 PM
dumbbell added inline comments.
sys/compat/linuxkpi/common/include/linux/cpufreq.h
7

I think the LINUXKPI prefix should be added, as LINUX reflects the parent directory of the header here.

siri_racha.ca updated this revision to Diff 187487.Wed, Sep 23, 7:57 AM
siri_racha.ca marked an inline comment as done.
siri_racha.ca marked an inline comment as done.
siri_racha.ca added inline comments.
sys/compat/linuxkpi/common/include/linux/cpufreq.h
7

Fixed, coped compat.h style and did _LINUXKPI_LINUX_CPUFREQ_H_

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
29 lines

Diff 186642

View Options

sys/compat/linuxkpi/common/include/linux/cpufreq.h

Loading...