Page MenuHomeFreeBSD
Differential D59620

ldscript.powerpc*: Keep .data.rel.ro out of PT_DYNAMIC
AcceptedPublic
Actions

Authored by mchoo on Sat, Sep 12, 1:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 17, 4:53 PM
Unknown Object (File)
Thu, Sep 17, 1:01 PM
Unknown Object (File)
Wed, Sep 16, 5:09 PM
Unknown Object (File)
Wed, Sep 16, 4:32 AM
Unknown Object (File)
Wed, Sep 16, 1:47 AM
Unknown Object (File)
Wed, Sep 16, 1:42 AM
Unknown Object (File)
Wed, Sep 16, 1:35 AM
Unknown Object (File)
Tue, Sep 15, 7:21 PM
View All 17 Files
Subscribers
imp
olce

Details

Reviewers
jhibbits
adrian
jrtc27
jhb
Group Reviewers
PowerPC
Summary

When .got2 is empty, the orphan .data.rel.ro output section follows
.dynamic and inherits both its :kernel and :dynamic program-header
assignments. This makes PT_DYNAMIC cover .data.rel.ro as well as the
actual dynamic table. On powerpc64le, its resulting size may not even
be a multiple of Elf64_Dyn.

Describe .data.rel.ro explicitly and assign it only to :kernel,
terminating :dynamic inheritance on powerpc, powerpc64, and powerpc64le.

MFC after: 2 weeks
MFC to: stable/14, stable/15
Sponsored by: FreeBSD Foundation, Reliable Computer Systems Lab

Test Plan

readelf -l shows that .data.rel.ro does not appear in 01 (Dynamic) segment after this patch.
ppc64{be,le} boots. Not tested on ppc32.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 76807
Build 73690: arc lint + arc unit

Event Timeline

mchoo created this revision.Sat, Sep 12, 1:55 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, Sep 12, 1:55 PM
mchoo requested review of this revision.Sat, Sep 12, 1:55 PM
Harbormaster completed remote builds in B76801: Diff 186523.Sat, Sep 12, 1:55 PM
mchoo added reviewers: PowerPC, jhibbits, adrian, jrtc27.Sat, Sep 12, 1:55 PM
mchoo added a reviewer: jhb.Sat, Sep 12, 2:01 PM
adrian added a comment.Sat, Sep 12, 5:12 PM

Would you mind adding a comment explaining this above the section name so we don't forget why ?

mchoo updated this revision to Diff 186535.Sat, Sep 12, 6:35 PM

Reflect @adrian's suggestion

Harbormaster completed remote builds in B76807: Diff 186535.Sat, Sep 12, 6:35 PM
adrian added a comment.Sat, Sep 12, 11:05 PM

also just to be clear - did you boot test this on something? :-P :-)

mchoo added a comment.Sat, Sep 12, 11:59 PM
In D59620#1368197, @adrian wrote:

also just to be clear - did you boot test this on something? :-P :-)

Tested on ppc64{be,le} on IBM LC Power 9. I didn't test on ppc32 although I'm pretty sure it will pass.

mchoo edited the summary of this revision. (Show Details)Sat, Sep 12, 11:59 PM
mchoo edited the test plan for this revision. (Show Details)Sun, Sep 13, 5:55 PM
adrian accepted this revision.Sun, Sep 13, 6:18 PM

I'm ok with it, let's wait for @jhibbits to chime in too.

This revision is now accepted and ready to land.Sun, Sep 13, 6:18 PM
jhibbits accepted this revision.Sun, Sep 13, 7:11 PM
mchoo added a comment.EditedMon, Sep 14, 1:45 AM

ping @jhb for mentor approval

edit: Do I need another mentor approval for MFC?

mchoo added a subscriber: olce.Fri, Sep 18, 4:03 PM

ping @olce for mentor approval

Revision Contents
Changeset List

PathSize
sys/
conf/
7 lines
7 lines
7 lines

Diff 186535

View Options

sys/conf/ldscript.powerpc

Loading...
View Options

sys/conf/ldscript.powerpc64

Loading...
View Options

sys/conf/ldscript.powerpc64le

Loading...