Page MenuHomeFreeBSD

icmp: Limit routing table updates to the FIB of the redirect
AcceptedPublic

Authored by markj on Thu, Sep 10, 10:54 AM.
Tags
None
Referenced Files
F171961628: D59567.diff
Mon, Sep 14, 11:07 PM
Unknown Object (File)
Sun, Sep 13, 6:32 PM
Unknown Object (File)
Sun, Sep 13, 12:12 PM
Unknown Object (File)
Sun, Sep 13, 11:49 AM
Unknown Object (File)
Sun, Sep 13, 11:28 AM
Unknown Object (File)
Sun, Sep 13, 9:50 AM
Unknown Object (File)
Fri, Sep 11, 9:30 AM
Unknown Object (File)
Fri, Sep 11, 9:26 AM
Subscribers

Details

Reviewers
melifaro
glebius
pouria
zlei
Group Reviewers
network
Summary

When we receive an ICMP redirect, rib_add_redirect() is used to apply
the redirect to all FIBs. This has been the case since support for
multiple FIBs was added. However, it seems rather dubious: the new
gateway might not be routable from all FIBs, and the validation done for
v4 redirects in icmp_verify_redirect_gateway() is only applied to the
FIB from which the redirect originated.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76741
Build 73624: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Thu, Sep 10, 10:57 AM

Not sure but it might help with PR292319

Not sure but it might help with PR292319

I guess not, since the problem is still there with drop_redirect=1.