There could be some performance issues related to the SSE/AVX transition state machine, but checking the Intel Software Optimization Manual, it seems like executing 128 bit AVX instructions seems unproblematic in any steady-state scenario.

Oh yeah, using the archlevel framework sounds like a good idea! I didn't even think about that, as it's specific to libc. Other libm functions may profit in the future.

In D59462#1365021, @fuz wrote:

Oh yeah, using the archlevel framework sounds like a good idea! I didn't even think about that, as it's specific to libc. Other libm functions may profit in the future.

Do you have any notes about the updated patch?

BTW, I was not able to come up with a C expression that can be used to initialize the function table, so I resorted to filling it in assembler same as is done for strings.

In D59462#1365088, @kib wrote:

In D59462#1365021, @fuz wrote:

Oh yeah, using the archlevel framework sounds like a good idea! I didn't even think about that, as it's specific to libc. Other libm functions may profit in the future.

Do you have any notes about the updated patch?

BTW, I was not able to come up with a C expression that can be used to initialize the function table, so I resorted to filling it in assembler same as is done for strings.

Oh the patch is fine, I just forgot to hit “approve.” I don't think the table can be initialised in C. I designed it this way to reduce the amounts of relocations and the table size, and I don't think C wants to do this stuff. We could do an inline assembly macro to build the table in C if you like.