Page MenuHomeFreeBSD
Differential D59462

lib/msun amd64: use AVX FMA instructions for fma(3) and fmaf(3) when available
Needs ReviewPublic
Actions

Authored by kib on Sun, Sep 6, 6:02 AM.
Tags
None
Referenced Files
F170888364: D59462.id186085.diff
Mon, Sep 7, 8:17 AM
F170881617: D59462.id185992.diff
Mon, Sep 7, 6:42 AM
F170876026: D59462.id186076.diff
Mon, Sep 7, 5:30 AM
F170832784: D59462.diff
Sun, Sep 6, 10:13 PM
Unknown Object (File)
Sun, Sep 6, 7:09 PM
Unknown Object (File)
Sun, Sep 6, 6:30 PM
Unknown Object (File)
Sun, Sep 6, 5:05 PM
Subscribers
imp

Details

Reviewers
emaste
dim
kfv
fuz

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Sun, Sep 6, 6:02 AM
Herald added a subscriber: imp. · View Herald TranscriptSun, Sep 6, 6:02 AM
kib requested review of this revision.Sun, Sep 6, 6:02 AM
kib added reviewers: emaste, dim, kfv, fuz.Sun, Sep 6, 3:19 PM
fuz accepted this revision.Sun, Sep 6, 3:31 PM

Love it!

This revision is now accepted and ready to land.Sun, Sep 6, 3:31 PM
fuz added a comment.Sun, Sep 6, 3:41 PM

There could be some performance issues related to the SSE/AVX transition state machine, but checking the Intel Software Optimization Manual, it seems like executing 128 bit AVX instructions seems unproblematic in any steady-state scenario.

kfv accepted this revision.Sun, Sep 6, 8:33 PM

Brilliant work. Thanks!

kib updated this revision to Diff 186076.Sun, Sep 6, 9:17 PM

Put added symbols into private namespace.
It does not matter for shared library, but helps static linking.

This revision now requires review to proceed.Sun, Sep 6, 9:17 PM
kib updated this revision to Diff 186085.Sun, Sep 6, 11:46 PM

Switch to use libc/amd64/string ARCHLEVEL infra to control the selection.

Revision Contents
Changeset List

PathSize
lib/
msun/
9 lines
amd64/
9 lines
24 lines
24 lines
src/
11 lines
12 lines

Diff 186085

View Options

lib/msun/Makefile

Loading...
View Options

lib/msun/amd64/Makefile.inc

Loading...
View Options

lib/msun/amd64/s_fma_avx.S

Loading...
View Options

lib/msun/amd64/s_fmaf_avx.S

Loading...
View Options

lib/msun/src/s_fma.c

Loading...
View Options

lib/msun/src/s_fmaf.c

Loading...