Page MenuHomeFreeBSD
Differential D59402

sched_4bsd: fix comment in maybe_preempt()
ClosedPublic
Actions

Authored by mchoo on Sep 4 2026, 5:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 6, 8:50 AM
Unknown Object (File)
Mon, Oct 5, 11:58 AM
Unknown Object (File)
Sun, Oct 4, 4:13 AM
Unknown Object (File)
Sat, Oct 3, 11:05 AM
Unknown Object (File)
Sat, Oct 3, 10:58 AM
Unknown Object (File)
Sat, Oct 3, 2:14 AM
Unknown Object (File)
Fri, Oct 2, 8:51 PM
Unknown Object (File)
Fri, Oct 2, 5:59 PM
View All 75 Files
Subscribers
imp
olce

Details

Reviewers
jhb
olce
Group Reviewers
scheduler
Commits
rGefd9712ed3a1: sched_4bsd: fix comment in maybe_preempt()
rG48cef9960769: sched_4bsd: fix comment in maybe_preempt()
rG351f6733180c: sched_4bsd: fix comment in maybe_preempt()
Summary

The comment says the new thread's priority is not a realtime priority
while the code states pri > PRI_MAX_ITHD which is interrupt priorities
not realtime.

MFC after: 2 weeks
MFC to: stable/14, stable/15
Sponsored by: FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 76597
Build 73480: arc lint + arc unit

Event Timeline

mchoo created this revision.Sep 4 2026, 5:37 PM
Herald added subscribers: olce, imp. · View Herald TranscriptSep 4 2026, 5:37 PM
mchoo requested review of this revision.Sep 4 2026, 5:37 PM
Harbormaster completed remote builds in B76510: Diff 185838.Sep 4 2026, 5:37 PM
mchoo added a parent revision: D59401: sched: fix kern.sched.{4bsd,ule}.slice.Sep 4 2026, 5:37 PM
mchoo added a child revision: D59403: sched_4bsd: move comment to correct location.
olce requested changes to this revision.Sep 6 2026, 4:39 PM

Grammar.

sys/kern/sched_4bsd.c
347 ↗(On Diff #185838)
This revision now requires changes to proceed.Sep 6 2026, 4:39 PM
mchoo updated this revision to Diff 186015.Sep 6 2026, 6:40 PM

Reflect @olce's review

Harbormaster completed remote builds in B76597: Diff 186015.Sep 6 2026, 6:40 PM
mchoo updated this revision to Diff 186017.Sep 6 2026, 6:41 PM

Oops wrong commit

Harbormaster completed remote builds in B76599: Diff 186017.Sep 6 2026, 6:41 PM
mchoo marked an inline comment as done.Sep 6 2026, 6:41 PM
olce accepted this revision.Sep 6 2026, 9:38 PM
This revision is now accepted and ready to land.Sep 6 2026, 9:38 PM
Closed by commit rG351f6733180c: sched_4bsd: fix comment in maybe_preempt() (authored by mchoo). · Explain WhyFri, Sep 18, 2:15 PM
This revision was automatically updated to reflect the committed changes.
mchoo added a commit: rG351f6733180c: sched_4bsd: fix comment in maybe_preempt().
mchoo added a commit: rG48cef9960769: sched_4bsd: fix comment in maybe_preempt().Fri, Oct 2, 3:35 PM
mchoo added a commit: rGefd9712ed3a1: sched_4bsd: fix comment in maybe_preempt().Fri, Oct 2, 3:50 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 186015

View Options

sys/kern/sched_ule.c

Loading...