Page MenuHomeFreeBSD
Differential D59402

sched_4bsd: fix comment in maybe_preempt()
AcceptedPublic
Actions

Authored by mchoo on Fri, Sep 4, 5:37 PM.
Tags
None
Referenced Files
F170952794: D59402.id185838.diff
Mon, Sep 7, 8:07 PM
F170952132: D59402.id.diff
Mon, Sep 7, 8:00 PM
F170943777: D59402.id185838.diff
Mon, Sep 7, 6:44 PM
F170893352: D59402.id.diff
Mon, Sep 7, 9:19 AM
Unknown Object (File)
Sun, Sep 6, 7:41 PM
Unknown Object (File)
Sun, Sep 6, 7:40 PM
Unknown Object (File)
Sun, Sep 6, 10:22 AM
Unknown Object (File)
Fri, Sep 4, 9:55 PM
View All 9 Files
Subscribers
imp
olce

Details

Reviewers
jhb
olce
Group Reviewers
scheduler
Summary

The comment says the new thread's priority is not a realtime priority
while the code states pri > PRI_MAX_ITHD which is interrupt priorities
not realtime.

MFC after: 2 weeks
MFC to: stable/14, stable/15
Sponsored by: FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 76597
Build 73480: arc lint + arc unit

Event Timeline

mchoo created this revision.Fri, Sep 4, 5:37 PM
Herald added subscribers: olce, imp. · View Herald TranscriptFri, Sep 4, 5:37 PM
mchoo requested review of this revision.Fri, Sep 4, 5:37 PM
Harbormaster completed remote builds in B76510: Diff 185838.Fri, Sep 4, 5:37 PM
mchoo added a parent revision: D59401: sched: fix kern.sched.{4bsd,ule}.slice.Fri, Sep 4, 5:37 PM
mchoo added a child revision: D59403: sched_4bsd: move comment to correct location.
olce requested changes to this revision.Sun, Sep 6, 4:39 PM

Grammar.

sys/kern/sched_4bsd.c
347 ↗(On Diff #185838)
This revision now requires changes to proceed.Sun, Sep 6, 4:39 PM
mchoo updated this revision to Diff 186015.Sun, Sep 6, 6:40 PM

Reflect @olce's review

Harbormaster completed remote builds in B76597: Diff 186015.Sun, Sep 6, 6:40 PM
mchoo updated this revision to Diff 186017.Sun, Sep 6, 6:41 PM

Oops wrong commit

Harbormaster completed remote builds in B76599: Diff 186017.Sun, Sep 6, 6:41 PM
mchoo marked an inline comment as done.Sun, Sep 6, 6:41 PM
olce accepted this revision.Sun, Sep 6, 9:38 PM
This revision is now accepted and ready to land.Sun, Sep 6, 9:38 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines

Diff 186015

View Options

sys/kern/sched_ule.c

Loading...