sched_4bsd: fix comment in maybe_preempt()
ClosedPublic
Actions

Authored by mchoo on Fri, Sep 4, 5:37 PM.

Details

Reviewers

jhb
olce

Group Reviewers

scheduler

Commits

rGefd9712ed3a1: sched_4bsd: fix comment in maybe_preempt()
rG48cef9960769: sched_4bsd: fix comment in maybe_preempt()
rG351f6733180c: sched_4bsd: fix comment in maybe_preempt()

Summary

The comment says the new thread's priority is not a realtime priority
while the code states pri > PRI_MAX_ITHD which is interrupt priorities
not realtime.

MFC after: 2 weeks
MFC to: stable/14, stable/15
Sponsored by: FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mchoo created this revision.Fri, Sep 4, 5:37 PM

Herald added subscribers: olce, imp. · View Herald TranscriptFri, Sep 4, 5:37 PM

mchoo requested review of this revision.Fri, Sep 4, 5:37 PM

Harbormaster completed remote builds in B76510: Diff 185838.Fri, Sep 4, 5:37 PM

mchoo added a parent revision: D59401: sched: fix kern.sched.{4bsd,ule}.slice.Fri, Sep 4, 5:37 PM

mchoo added a child revision: D59403: sched_4bsd: move comment to correct location.

Grammar.

sys/kern/sched_4bsd.c
348

This revision now requires changes to proceed.Sun, Sep 6, 4:39 PM

Reflect @olce's review

Harbormaster completed remote builds in B76597: Diff 186015.Sun, Sep 6, 6:40 PM

Oops wrong commit

Harbormaster completed remote builds in B76599: Diff 186017.Sun, Sep 6, 6:41 PM

mchoo marked an inline comment as done.Sun, Sep 6, 6:41 PM

olce accepted this revision.Sun, Sep 6, 9:38 PM

This revision is now accepted and ready to land.Sun, Sep 6, 9:38 PM

Closed by commit rG351f6733180c: sched_4bsd: fix comment in maybe_preempt() (authored by mchoo). · Explain WhyFri, Sep 18, 2:15 PM

This revision was automatically updated to reflect the committed changes.

mchoo added a commit: rG351f6733180c: sched_4bsd: fix comment in maybe_preempt().

mchoo added a commit: rG48cef9960769: sched_4bsd: fix comment in maybe_preempt().Fri, Oct 2, 3:35 PM

mchoo added a commit: rGefd9712ed3a1: sched_4bsd: fix comment in maybe_preempt().Fri, Oct 2, 3:50 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

sched_4bsd.c

2 lines

Diff 187103

View Options

sched_4bsd: fix comment in maybe_preempt()ClosedPublicActions