Page MenuHomeFreeBSD

sched_4bsd: update function name in comment
AcceptedPublic

Authored by mchoo on Fri, Sep 4, 5:36 PM.
Tags
None
Referenced Files
F170519009: D59397.diff
Sat, Sep 5, 5:17 AM
F170516996: D59397.id.diff
Sat, Sep 5, 5:00 AM
F170482295: D59397.id185833.diff
Sat, Sep 5, 1:00 AM
F170466906: D59397.id185874.diff
Fri, Sep 4, 11:20 PM
F170466335: D59397.diff
Fri, Sep 4, 11:17 PM
F170451857: D59397.id185833.diff
Fri, Sep 4, 9:44 PM
F170449298: D59397.diff
Fri, Sep 4, 9:26 PM
Subscribers

Details

Reviewers
jhb
olce
Group Reviewers
scheduler
Summary

In b43179fbe815 ("Create a new scheduler api..."), schedclock() was
renamed to sched_clock() but the function name in the comment remained
still. Update the comment to reflect up-to-date name for schedclock().

Fixes: b43179fbe815 ("Create a new scheduler api...")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 76540
Build 73423: arc lint + arc unit

Event Timeline

mchoo requested review of this revision.Fri, Sep 4, 5:36 PM

Mmm... Certainly, schedclock() should have been updated to sched_clock() in commit b43179fbe815 ("Create a new scheduler api..."), which renamed the function. But then, it is still technically true even today that sched_clock() actually updates the mentioned fields, it's just that it does so indirectly (through sched_clock_tick(), of which sched_clock() is the only caller). Keeping the mention of the upper-level function / entry point to the scheduler could be seen as clearer. The recently-introduced possibility to have multiple schedulers compiled in the same kernel lead to some ugly renames, and that's why sched_clock() was renamed to sched_4bsd_clock(). Conceptually, though, the interface function triggering the updates is still sched_clock() (it's how it is referenced from outside 4BSD). I'd slightly prefer having sched_clock() in the comment.

This revision is now accepted and ready to land.Sat, Sep 5, 1:35 PM