vfs: Avoid integer overflow when faulting
AcceptedPublic
Actions

Authored by des on Fri, Sep 4, 6:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 13, 10:23 AM

	Unknown Object (File)
	Sat, Sep 12, 4:23 PM

	Unknown Object (File)
	Sat, Sep 12, 6:06 AM

	Unknown Object (File)
	Sat, Sep 12, 12:15 AM

	Unknown Object (File)
	Fri, Sep 11, 7:53 PM

	Unknown Object (File)
	Fri, Sep 11, 7:02 PM

	Unknown Object (File)
	Fri, Sep 11, 6:48 PM

	Unknown Object (File)
	Fri, Sep 11, 6:31 PM

View All 25 Files

Subscribers

imp

olce

Details

Reviewers

kib
markj
olce

Summary

PR: 298159
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76522
Build 73405: arc lint + arc unit

Event Timeline

des created this revision.Fri, Sep 4, 6:44 PM

Herald added subscribers: olce, imp. · View Herald TranscriptFri, Sep 4, 6:44 PM

des requested review of this revision.Fri, Sep 4, 6:44 PM

Harbormaster completed remote builds in B76522: Diff 185852.Fri, Sep 4, 6:44 PM

des added a child revision: D59413: uiomove: Use size_t for the length argument.Fri, Sep 4, 6:44 PM

kib accepted this revision.Fri, Sep 4, 7:40 PM

This revision is now accepted and ready to land.Fri, Sep 4, 7:40 PM

olce accepted this revision.Fri, Sep 4, 9:47 PM

So this commit message needs to briefly summarize the bug information, specifically, that uiomove takes an int, while uio_resid is a size_t.

des mentioned this in D59413: uiomove: Use size_t for the length argument.Sat, Sep 5, 11:12 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_vnops.c

8 lines

Diff 185852

View Options

vfs: Avoid integer overflow when faultingAcceptedPublicActions