tcp_socket: fix build with ATF 0.22+
ClosedPublic
Actions

Authored by ngie on Mon, Aug 31, 2:36 AM.

Details

Reviewers

cc
tuexen

Group Reviewers

transport

Commits

rG4aea6ea2eb40: tests/sys/netinet/tcp_socket: fix build with ATF 0.22+

Summary

Confirm that creating clients/sockets was successful by testing the
result separate from the assignment and test that the return value is
not -1 instead of testing that the value returned is non-zero.

This fixes the build with [ATF 0.22+][1].

MFC after: 2 weeks
Reported by: clang (-Wparenthesis)

1: https://github.com/freebsd/atf/pull/72

Test Plan

The test passes after this change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 76342
Build 73225: arc lint + arc unit

Event Timeline

ngie created this revision.Mon, Aug 31, 2:36 AM

Herald added a reviewer: transport. · View Herald TranscriptMon, Aug 31, 2:36 AM

Herald added subscribers: glebius, melifaro, asomers, imp. · View Herald Transcript

ngie requested review of this revision.Mon, Aug 31, 2:36 AM

Harbormaster completed remote builds in B76342: Diff 185464.Mon, Aug 31, 2:36 AM

ngie edited the test plan for this revision. (Show Details)Mon, Aug 31, 2:42 AM

ngie edited the summary of this revision. (Show Details)Mon, Aug 31, 3:00 AM

ngie edited the test plan for this revision. (Show Details)

Looks good to me.

This revision is now accepted and ready to land.Tue, Sep 1, 1:15 PM

tuexen accepted this revision.Tue, Sep 1, 1:32 PM

Closed by commit rG4aea6ea2eb40: tests/sys/netinet/tcp_socket: fix build with ATF 0.22+ (authored by ngie). · Explain WhyWed, Sep 2, 7:40 AM

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG4aea6ea2eb40: tests/sys/netinet/tcp_socket: fix build with ATF 0.22+.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netinet/

tcp_socket.c

12 lines

Diff 185464

View Options

tests/sys/netinet/tcp_socket.c

tests/sys/netinet/tcp_socket: fix build with ATF 0.22+ClosedPublicActions