Differential D59165

nvme.4: Canonicalize LOADER TUNABLES
ClosedPublic
Actions

Authored by ziaee on Tue, Aug 25, 5:26 AM.

Tags

None

Referenced Files

	F169514791: D59165.id185230.diff
	Tue, Sep 1, 6:58 PM

	F169398130: D59165.id185230.diff
	Tue, Sep 1, 10:26 AM

	F169393164: D59165.id185230.diff
	Tue, Sep 1, 10:02 AM

	F169389196: D59165.diff
	Tue, Sep 1, 9:44 AM

	F169343041: D59165.id184947.diff
	Tue, Sep 1, 6:16 AM

	F169257086: D59165.diff
	Tue, Sep 1, 2:03 AM

	F169254649: D59165.id.diff
	Tue, Sep 1, 1:53 AM

	Unknown Object (File)
	Mon, Aug 31, 5:35 PM

View All 26 Files

Subscribers

Details

Reviewers

adrian
seuros
dteske
imp
saper_saper.info

Group Reviewers

Commits

rG59f363d0c21a: nvme.4: Canonicalize LOADER TUNABLES

Summary

This improves the style for consistency with the rest of the manual
and adds the tunables to the search database.

I was not quite sure what to do with the extra kernel configuration
option, so I moved it to HISTORY. example(4) shows it in DESCIRPTION.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ziaee created this revision.Tue, Aug 25, 5:26 AM

Herald added a subscriber: dab. · View Herald TranscriptTue, Aug 25, 5:26 AM

ziaee requested review of this revision.Tue, Aug 25, 5:26 AM

Harbormaster completed remote builds in B76070: Diff 184947.Tue, Aug 25, 5:26 AM

seuros added inline comments.Thu, Aug 27, 10:07 AM

share/man/man4/nvme.4
281	This look like a Git blame place. A person reading the man page should not be feed past failed decisions..

Thanks for looking it over @seuros. How's this?

Harbormaster completed remote builds in B76222: Diff 185230.Thu, Aug 27, 4:38 PM

ziaee marked an inline comment as done.Thu, Aug 27, 4:38 PM

seuros accepted this revision.Thu, Aug 27, 4:39 PM

This revision is now accepted and ready to land.Thu, Aug 27, 4:39 PM

ziaee added inline comments.Thu, Aug 27, 4:47 PM

share/man/man4/nvme.4
191	I'd like to increase the specificity here. Is this the nvme controller in the chipset or the nvme controller in the disk? The previous iteration said card, which is equally unspecific, and there is no "card" in many devices.

Closed by commit rG59f363d0c21a: nvme.4: Canonicalize LOADER TUNABLES (authored by ziaee). · Explain WhyFri, Aug 28, 7:03 PM

This revision was automatically updated to reflect the committed changes.

ziaee added a commit: rG59f363d0c21a: nvme.4: Canonicalize LOADER TUNABLES.

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

149 lines

Diff 185362

share/man/man4/nvme.4

Loading...