I think this should only do a vacuum (integrity check).
So far we have not been able to create deterministic pkgbase images.

In D59046#1354947, @jlduran wrote:

I think this should only do a vacuum (integrity check).
So far we have not been able to create deterministic pkgbase images.

As per my understanding, I'd like to keep the dump rather than dropping it, the function just dumps the db as a precondition for someday diffing/reproducing images. Once pkgbase builds are reproducible, this becomes the hook that lets us verify it, without another patch reintroducing it then.
Please let me know your view on this, then will change accordingly.

In D59046#1356180, @senguptaangshuman17_gmail.com wrote:

In D59046#1354947, @jlduran wrote:

I think this should only do a vacuum (integrity check).
So far we have not been able to create deterministic pkgbase images.

As per my understanding, I'd like to keep the dump rather than dropping it, the function just dumps the db as a precondition for someday diffing/reproducing images.

OK. Then, this must be stated in the commit message, and clarified in the comment above the function. I'm not sure if that is even possible.

Once pkgbase builds are reproducible, this becomes the hook that lets us verify it, without another patch reintroducing it then.

The pkgbase builds are currently reproducible. The installations are not. Since we are installing (pkg install), and that process populates an sqlite3 database, the resulting database file is not deterministic.