Page MenuHomeFreeBSD
Differential D58959

nanobsd: Disable pkg repositories on target image
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Wed, Aug 19, 10:19 AM.
Tags
None
Referenced Files
F168254952: D58959.id184599.diff
Thu, Aug 27, 5:13 AM
Unknown Object (File)
Wed, Aug 26, 11:07 AM
Unknown Object (File)
Wed, Aug 26, 9:26 AM
Unknown Object (File)
Wed, Aug 26, 4:00 AM
Unknown Object (File)
Tue, Aug 25, 9:39 PM
Unknown Object (File)
Tue, Aug 25, 6:40 PM
Unknown Object (File)
Tue, Aug 25, 6:31 PM
Unknown Object (File)
Tue, Aug 25, 6:16 PM
View All 35 Files
Subscribers
imp

Details

Reviewers
jlduran
jrm
ashish
Summary

Ship images with every pkg repository disabled in FreeBSD.conf,
preventing pkg from attempting operations that are not allowed
on a read-only root.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75970
Build 72853: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Wed, Aug 19, 10:19 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 10:19 AM
senguptaangshuman17_gmail.com requested review of this revision.Wed, Aug 19, 10:19 AM
Harbormaster completed remote builds in B75712: Diff 184324.Wed, Aug 19, 10:19 AM
senguptaangshuman17_gmail.com added a parent revision: D58958: nanobsd: Fix pkg audit.Wed, Aug 19, 10:20 AM
senguptaangshuman17_gmail.com added a child revision: D58960: nanobsd: Fix target pkg database /tmp symlink and timestamps.
senguptaangshuman17_gmail.com updated this revision to Diff 184459.Thu, Aug 20, 10:10 AM
Harbormaster completed remote builds in B75793: Diff 184459.Thu, Aug 20, 10:10 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184507.Thu, Aug 20, 12:22 PM
Harbormaster completed remote builds in B75836: Diff 184507.Thu, Aug 20, 12:22 PM
jlduran added inline comments.Thu, Aug 20, 3:57 PM
tools/tools/nanobsd/defaults.sh
674

XXXJL comments should be avoided. Those should either be removed or "promoted" to XXX comments.

senguptaangshuman17_gmail.com updated this revision to Diff 184599.Thu, Aug 20, 7:02 PM

Address review comments: normalize comment

Herald added a reviewer: scheduler. · View Herald TranscriptThu, Aug 20, 7:02 PM
Harbormaster completed remote builds in B75913: Diff 184599.Thu, Aug 20, 7:02 PM
senguptaangshuman17_gmail.com edited parent revisions, added: D58956: nanobsd: Use local repository cache for precompiled package base builds; removed: D58958: nanobsd: Fix pkg audit.Thu, Aug 20, 7:04 PM
senguptaangshuman17_gmail.com edited parent revisions, added: D58957: nanobsd: Remove chflags call in install_world(); removed: D58956: nanobsd: Use local repository cache for precompiled package base builds.Thu, Aug 20, 7:16 PM
senguptaangshuman17_gmail.com added a child revision: D59044: nanobsd: Add _xxx_fix_pkg_permissions.
lwhsu removed a reviewer: scheduler.Thu, Aug 20, 8:15 PM
jlduran mentioned this in D58980: nanobsd: Do not ship with a FreeBSD-local directory.Fri, Aug 21, 1:52 PM

Remove git conflict markers.

senguptaangshuman17_gmail.com updated this revision to Diff 184752.Sat, Aug 22, 10:31 PM

Clean up merge conflict markers in defaults.sh

Harbormaster completed remote builds in B75970: Diff 184752.Sat, Aug 22, 10:31 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184809.Sun, Aug 23, 8:22 PM
Harbormaster completed remote builds in B75996: Diff 184809.Sun, Aug 23, 8:22 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184966.Tue, Aug 25, 6:11 AM
Harbormaster completed remote builds in B76089: Diff 184966.Tue, Aug 25, 6:11 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184996.Tue, Aug 25, 7:59 AM

Rebase stack on top of D59043 update

Harbormaster completed remote builds in B76119: Diff 184996.Tue, Aug 25, 7:59 AM
jlduran added a comment.Wed, Aug 26, 3:01 PM

I think this commit can be squashed with D58951, I see no reason to keep this in a separate commit.

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
25 lines

Diff 184752

View Options

tools/tools/nanobsd/defaults.sh

Loading...