sound: Remove unncessary locking in sysctl_hw_snd_hwvol_mixer()
Needs ReviewPublic
Actions

Authored by christos on Sat, Aug 22, 1:43 PM.

Tags

None

Referenced Files

	F172309043: D59109.diff
	Thu, Sep 17, 3:38 PM

	Unknown Object (File)
	Wed, Sep 16, 6:17 AM

	Unknown Object (File)
	Mon, Sep 14, 12:26 AM

	Unknown Object (File)
	Sun, Sep 13, 4:15 PM

	Unknown Object (File)
	Sun, Sep 13, 3:15 PM

	Unknown Object (File)
	Sat, Sep 12, 11:47 PM

	Unknown Object (File)
	Sat, Sep 12, 11:47 PM

	Unknown Object (File)
	Sat, Sep 12, 11:10 AM

View All 55 Files

Subscribers

imp

Details

Reviewers

markj
emaste
kib

Summary

The locking around strlcpy() was because of m->hwvol_mixer, but this is
just an int, so we don't need to lock in this case. Instead lock only
when m->hwvol_mixer is written.

While here, add parentheses around the returns.

Sponsored by: The FreeBSD Foundation
MFC after: 1 month

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75964
Build 72847: arc lint + arc unit

Event Timeline

christos created this revision.Sat, Aug 22, 1:43 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Aug 22, 1:43 PM

christos requested review of this revision.Sat, Aug 22, 1:43 PM

Harbormaster completed remote builds in B75964: Diff 184737.Sat, Aug 22, 1:43 PM

christos added a child revision: D59110: sound: Lock around mixer_set*() in mixer_init() for consistency.Sat, Aug 22, 1:43 PM

christos added a parent revision: D59078: sound: Improve some mixer return values and their handling.Sat, Aug 22, 1:43 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

mixer.c

18 lines

Diff 184737

View Options

sound: Remove unncessary locking in sysctl_hw_snd_hwvol_mixer()Needs ReviewPublicActions