Page MenuHomeFreeBSD
Differential D59071

sound: Embed mixer cdev in snd_mixer
Needs ReviewPublic
Actions

Authored by christos on Fri, Aug 21, 12:42 PM.
Tags
None
Referenced Files
F167741190: D59071.id184637.diff
Mon, Aug 24, 5:04 AM
Unknown Object (File)
Sat, Aug 22, 2:50 AM
Unknown Object (File)
Sat, Aug 22, 2:37 AM
Unknown Object (File)
Sat, Aug 22, 1:53 AM
Unknown Object (File)
Fri, Aug 21, 5:45 PM
Unknown Object (File)
Fri, Aug 21, 1:33 PM
Unknown Object (File)
Fri, Aug 21, 1:28 PM
Subscribers
imp

Details

Reviewers
markj
emaste
kib
Summary

The mixer cdev belongs to the mixer, not to the PCM device, so move it
from snddev_info->mixer_dev into a new snd_mixer->cdev field. snd_mixer
itself is now included in snddev_info.

Also add a MIXER_REGISTERED() macro similar to PCM_REGISTERED().

Sponsored by: The FreeBSD Foundation
MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75936
Build 72819: arc lint + arc unit

Event Timeline

christos created this revision.Fri, Aug 21, 12:42 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Aug 21, 12:42 PM
Harbormaster completed remote builds in B75936: Diff 184637.Fri, Aug 21, 12:42 PM
christos requested review of this revision.Fri, Aug 21, 12:42 PM
christos added a child revision: D59073: sound: Defer macio codec volume writes to a task.Fri, Aug 21, 12:44 PM
christos added a parent revision: D59070: sound: Simplify how snd_mixer is fetched and how the cdev is created.
kib added inline comments.Sat, Aug 22, 6:18 AM
sys/dev/sound/pcm/mixer.c
719

Do you need to clear m->cdev? What is the lifetime for struct snd_mixer?

christos added inline comments.Sat, Aug 22, 11:20 AM
sys/dev/sound/pcm/mixer.c
719

snd_mixer gets freed in this function here, which is called by pcm_unregister() during detach. I think we should be fine and not NULL it.

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pci/
2 lines
pcm/
16 lines
3 lines
37 lines
1 line

Diff 184637

View Options

sys/dev/sound/pci/es137x.c

Loading...
View Options

sys/dev/sound/pcm/dsp.c

Loading...
View Options

sys/dev/sound/pcm/mixer.h

Loading...
View Options

sys/dev/sound/pcm/mixer.c

Loading...
View Options

sys/dev/sound/pcm/sound.h

Loading...