Details

Reviewers

jlduran
jrm
ashish

Summary

Accept sizes in bytes instead of 512-byte sectors. Replace strsuftoll with strtobytes, which accepts powers of two and powers of ten.

For existing configurations migrating to the default plan, users who wish to keep using 512-byte sector counts can append an 's' (for sector) suffix to their variables (e.g., NANO_MEDIASIZE=4000000s, NANO_CONFSIZE=2048s).

Legacy configurations setting NANO_PLAN=legacy continue working with raw sector counts without modification.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75849
Build 72732: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Wed, Aug 19, 10:24 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 10:24 AM

senguptaangshuman17_gmail.com requested review of this revision.Wed, Aug 19, 10:24 AM

Harbormaster completed remote builds in B75722: Diff 184335.Wed, Aug 19, 10:24 AM

senguptaangshuman17_gmail.com added a parent revision: D58968: nanobsd: Add basic update/rollback scripts.Wed, Aug 19, 10:24 AM

senguptaangshuman17_gmail.com added a child revision: D58970: nanobsd: Change the location of SSH authorized keys.

jlduran mentioned this in D58964: nanobsd: Add gpt support.Wed, Aug 19, 4:39 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184469.Thu, Aug 20, 10:11 AM

Harbormaster completed remote builds in B75803: Diff 184469.Thu, Aug 20, 10:11 AM

senguptaangshuman17_gmail.com updated this revision to Diff 184520.Thu, Aug 20, 12:24 PM

Harbormaster completed remote builds in B75849: Diff 184520.Thu, Aug 20, 12:24 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184541.Thu, Aug 20, 2:12 PM

Harbormaster completed remote builds in B75867: Diff 184541.Thu, Aug 20, 2:12 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184547.Thu, Aug 20, 2:26 PM

Harbormaster completed remote builds in B75872: Diff 184547.Thu, Aug 20, 2:26 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184560.Thu, Aug 20, 3:11 PM

Harbormaster completed remote builds in B75883: Diff 184560.Thu, Aug 20, 3:11 PM

senguptaangshuman17_gmail.com edited parent revisions, added: D58963: nanobsd: Disable dumpdev; removed: D58968: nanobsd: Add basic update/rollback scripts.Thu, Aug 20, 3:14 PM

senguptaangshuman17_gmail.com added a child revision: D58964: nanobsd: Add gpt support.

senguptaangshuman17_gmail.com removed a child revision: D58970: nanobsd: Change the location of SSH authorized keys.

senguptaangshuman17_gmail.com updated this revision to Diff 184838.Sun, Aug 23, 11:03 PM

Harbormaster completed remote builds in B76024: Diff 184838.Sun, Aug 23, 11:03 PM

senguptaangshuman17_gmail.com updated this revision to Diff 184959.Tue, Aug 25, 6:10 AM

Harbormaster completed remote builds in B76082: Diff 184959.Tue, Aug 25, 6:10 AM

Rebase stack on top of D59043 update

Harbormaster completed remote builds in B76126: Diff 185003.Tue, Aug 25, 8:00 AM

senguptaangshuman17_gmail.com updated this revision to Diff 185107.Tue, Aug 25, 9:00 PM

Harbormaster completed remote builds in B76166: Diff 185107.Tue, Aug 25, 9:00 PM

Since this is a legacy-breaking change (perhaps the most significant one), we should provide an easy migration path. For example, in the commit message, we can explain that users who want to keep using sector sizes could add an s (for sector) suffix to its current values when migrating to the default plan, this is a deliberate change from strsuftoll, which uses b (for block) for that same purpose.