Page MenuHomeFreeBSD
Differential D58965

nanobsd: Rename NANO_PLAN gpt -> default, bump NANO_RAM_TMPVARSIZE
AbandonedPublic
Actions

Authored by senguptaangshuman17_gmail.com on Wed, Aug 19, 10:22 AM.
Tags
None
Referenced Files
F168738402: D58965.id184465.diff
Sat, Aug 29, 9:49 PM
F168711228: D58965.id.diff
Sat, Aug 29, 6:35 PM
F168705418: D58965.id184465.diff
Sat, Aug 29, 5:47 PM
F168627782: D58965.diff
Sat, Aug 29, 8:06 AM
F168605069: D58965.diff
Sat, Aug 29, 5:48 AM
F168577435: D58965.diff
Sat, Aug 29, 2:44 AM
Unknown Object (File)
Fri, Aug 28, 8:12 PM
Unknown Object (File)
Fri, Aug 28, 1:18 AM
View All 40 Files
Subscribers
imp

Details

Reviewers
jlduran
jrm
ashish
imp
Summary

Default conveys more meaning and indicates this plan will become
the default.

Keep the legacy-only helpers together: they are no longer needed
elsewhere or are handled in a simpler way. NANO_MD_BACKING and
NANO_IMAGE_MBRONLY are also moved in, since legacy.sh is the only
plan that uses them.

The defaults.sh file is not meant to be executed directly.

Bump the default NANO_RAM_TMPVARSIZE since pkgbase requires
significantly more space in /var/db/pkg. Leave the legacy plan
default unchanged.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75845
Build 72728: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Wed, Aug 19, 10:22 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 10:22 AM
Harbormaster completed remote builds in B75718: Diff 184330.Wed, Aug 19, 10:22 AM
senguptaangshuman17_gmail.com requested review of this revision.Wed, Aug 19, 10:22 AM
senguptaangshuman17_gmail.com added a parent revision: D58964: nanobsd: Add gpt support.
senguptaangshuman17_gmail.com added a child revision: D58966: nanobsd: Put customizations in a separate file.
senguptaangshuman17_gmail.com updated this revision to Diff 184465.Thu, Aug 20, 10:11 AM
Harbormaster completed remote builds in B75799: Diff 184465.Thu, Aug 20, 10:11 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184516.Thu, Aug 20, 12:23 PM
Harbormaster completed remote builds in B75845: Diff 184516.Thu, Aug 20, 12:23 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184562.Thu, Aug 20, 3:11 PM
Harbormaster completed remote builds in B75885: Diff 184562.Thu, Aug 20, 3:11 PM
senguptaangshuman17_gmail.com added a reviewer: imp.Thu, Aug 20, 7:43 PM
Herald added a reviewer: scheduler. · View Herald TranscriptThu, Aug 20, 7:43 PM
lwhsu removed a reviewer: scheduler.Thu, Aug 20, 8:17 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184840.Sun, Aug 23, 11:03 PM
Harbormaster completed remote builds in B76026: Diff 184840.Sun, Aug 23, 11:03 PM
jlduran added a comment.Mon, Aug 24, 1:27 PM

Is this commit fixing something already in base?
If the answer is yes, then the commit message should carry the trailer:

Fixes:		<git log -n1 --format:'%h ("%s")' GIT-COMMIT-HASH>

If the answer is no, the it should be squashed with the commit that introduced this change in you revision stack, glancing over it, it looks like it should be D58964.

senguptaangshuman17_gmail.com abandoned this revision.Tue, Aug 25, 6:07 AM
senguptaangshuman17_gmail.com removed a child revision: D58966: nanobsd: Put customizations in a separate file.

Content merged into D58964.

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
127 lines
2 lines
130 lines
4 lines

Diff 184516

View Options

tools/tools/nanobsd/defaults.sh

Loading...
View Options

tools/tools/nanobsd/gpt.sh

Loading...
View Options

tools/tools/nanobsd/legacy.sh

Loading...
View Options

tools/tools/nanobsd/nanobsd.sh

Loading...