bhyve: Keep passthrough PCI power state virtual
ClosedPublic
Actions

Authored by kbowling on Mon, Aug 17, 5:42 PM.

Details

Reviewers

markj
jhb

Group Reviewers

bhyve

Summary

The passthrough Command register is emulated, but PMCSR writes were
sent directly to the physical function.  A guest D3hot-to-D0 transition
can perform an internal reset and clear physical Command while its
emulated copy remains enabled.

Cache the Power Management capability and keep the physical D-state
host-owned.  Emulate the guest D-state and advertise No_Soft_Reset so
the guest is not promised a function reset by a virtual power cycle.
Restore the assignment-time virtual state after a managed FLR.

MFC after:      2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling created this revision.Mon, Aug 17, 5:42 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMon, Aug 17, 5:42 PM

kbowling requested review of this revision.Mon, Aug 17, 5:42 PM

kbowling added a parent revision: D58864: bhyve: Manage passthrough devices across guest FLR.

markj added inline comments.Tue, Aug 18, 8:12 PM

usr.sbin/bhyve/pci_passthru.c
1326–1327	Is this an unrelated cleanup?
1351	It'd be good to introduce a helper function which factors out this expression, with a comment explaining it, as it appears quite a few times and isn't easy to read.