shmfd: consistently return size in 512 byte blocks for fstat st_blocks
ClosedPublic
Actions

Authored by kib on Wed, Aug 19, 2:33 AM.

Tags

None

Referenced Files

	F167909216: D58942.id184362.diff
	Tue, Aug 25, 9:31 AM

	F167857007: D58942.diff
	Tue, Aug 25, 1:14 AM

	F167837534: D58942.diff
	Mon, Aug 24, 9:50 PM

	Unknown Object (File)
	Mon, Aug 24, 5:17 PM

	Unknown Object (File)
	Mon, Aug 24, 4:57 PM

	Unknown Object (File)
	Mon, Aug 24, 3:13 AM

	Unknown Object (File)
	Sun, Aug 23, 9:31 PM

	Unknown Object (File)
	Sun, Aug 23, 4:25 PM

Subscribers

Details

Reviewers

markj
emaste

Commits

rG3a1bf59d195c: shmfd: consistently return size in 512 byte blocks for fstat(2) st_blocks

Summary

This is ABI-breaking change that could be considered as the bug fix.

Requested by: David Timber <dxdt@dev.snart.me>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Wed, Aug 19, 2:33 AM

Herald added subscribers: ziaee, olce, glebius, imp. · View Herald TranscriptWed, Aug 19, 2:33 AM

kib requested review of this revision.Wed, Aug 19, 2:33 AM

This revision is now accepted and ready to land.Wed, Aug 19, 2:45 AM

This needs a release note.

Closed by commit rG3a1bf59d195c: shmfd: consistently return size in 512 byte blocks for fstat(2) st_blocks (authored by kib). · Explain WhyWed, Aug 19, 2:47 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG3a1bf59d195c: shmfd: consistently return size in 512 byte blocks for fstat(2) st_blocks.

I think this breaks the accounting test in tests/sys/posixshm/posixshm_test.c.

Revision Contents
Changeset List

Path

Size

lib/

libsys/

stat.2

8 lines

sys/

kern/

uipc_shm.c

8 lines

Diff 184362

View Options

lib/libsys/stat.2