libc: Complete C23 <stdio.h> conformance
ClosedPublic
Actions

Authored by kfv on Fri, Aug 14, 12:34 PM.

Details

Reviewers

dteske
fuz
manu
olce

Commits

rGcd0727ec709b: libc: Add <stdio.h> C23 feature test macro
rG10d5a548596c: libc: Add _PRINTF_NAN_LEN_MAX per C23

Summary

Author: Faraz Vahedi <kfv@FreeBSD.org>
Date:   Fri Aug 14 15:13:23 2026 +0330

    libc: Add _PRINTF_NAN_LEN_MAX per C23
    
    Reviewed by:    fuz
    Approved by:    fuz (mentor)
    Differential Revision: https://reviews.freebsd.org/D58842

Author: Faraz Vahedi <kfv@FreeBSD.org>
Date:   Fri Aug 14 15:52:00 2026 +0330

    libc: Add <stdio.h> C23 feature test macro
    
    Define the __STDC_VERSION_STDIO_H__ feature test macro now that
    the header fully conforms to C23.
    
    Reviewed by:    fuz
    Approved by:    fuz (mentor)
    Differential Revision: https://reviews.freebsd.org/D58842

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 75587
Build 72470: arc lint + arc unit

Event Timeline

kfv created this revision.Fri, Aug 14, 12:34 PM

Herald added a reviewer: manu. · View Herald TranscriptFri, Aug 14, 12:34 PM

Herald added a reviewer: olce. · View Herald Transcript

Herald added subscribers: ziaee, dab, imp. · View Herald Transcript

kfv requested review of this revision.Fri, Aug 14, 12:34 PM

Harbormaster completed remote builds in B75587: Diff 184042.Fri, Aug 14, 12:34 PM

Please add the desired commit messages for reference.

Patch looks reasonable generally.

stand/libsa/geli/geliboot_internal.h
31	I'm not sure what this comment is getting at.

kfv added inline comments.Fri, Aug 14, 4:40 PM

stand/libsa/geli/geliboot_internal.h
31	I've been thinking about moving these deliberate defines, which exist solely to avoid unnecessary includes, into the same `_STANDALONE` branch used in `g_eli_hmac.c` for `g_eli.h`. Based on my findings so far, `g_eli.h` appears to be the only concern here, although I need to dig a bit deeper. This would have two advantages. First, we wouldn't need to define such guards just to prevent certain headers from being included. Second, we wouldn't need to revisit these defines whenever the value of a feature-test macro changes in the future. I actually left this comment as a reminder for myself, as well as a brief explanation for anyone who might question the change made by this patch, to address it in a day or two in a separate DR. But I can do it here instead if you think that would be cleaner. Your call.

fuz added inline comments.Fri, Aug 14, 4:46 PM

stand/libsa/geli/geliboot_internal.h
31	I think it's not a bad idea to have a comment, but it's hard to understand what this means to someone who is not you.

kfv added inline comments.Fri, Aug 14, 5:19 PM

stand/libsa/geli/geliboot_internal.h
31	Makes sense. I'd reword it to something clearer.

Finalise commit messages and improve the geliboot_internal.h comment block

Harbormaster completed remote builds in B75592: Diff 184062.Fri, Aug 14, 5:30 PM

kfv added inline comments.Fri, Aug 14, 5:32 PM

stand/libsa/geli/geliboot_internal.h
31	Does it look better now?

LGTM.

Approved for commit.
Do you wish to have these changes merged into stable/15? If yes, consider adding an MFC after tag. I recommend a wait of 1 month for new features, 1 week for bug fixes.
Same goes for your other C23 changes. You can MFC even if you did not add the relevant tag, but you'll only get a reminder if the tag is present.
If you wish to add "MFC after", just do it on commit. You do not need to ask for approval again.

This revision is now accepted and ready to land.Fri, Aug 14, 5:34 PM

Sure. Thanks!

Closed by commit rG10d5a548596c: libc: Add _PRINTF_NAN_LEN_MAX per C23 (authored by kfv). · Explain WhyFri, Aug 14, 7:33 PM

This revision was automatically updated to reflect the committed changes.

kfv added a commit: rG10d5a548596c: libc: Add _PRINTF_NAN_LEN_MAX per C23.

kfv added a commit: rGcd0727ec709b: libc: Add <stdio.h> C23 feature test macro.