Page MenuHomeFreeBSD
Differential D58781

makefs: Allow "legacy" as a valid ZFS mountpoint
ClosedPublic
Actions

Authored by jlduran on Aug 11 2026, 3:10 AM.
Tags
None
Referenced Files
F174421966: D58781.id183900.diff
Sat, Oct 3, 2:09 AM
Unknown Object (File)
Thu, Oct 1, 4:26 AM
Unknown Object (File)
Tue, Sep 29, 9:28 AM
Unknown Object (File)
Sun, Sep 27, 12:42 PM
Unknown Object (File)
Thu, Sep 24, 11:09 PM
Unknown Object (File)
Thu, Sep 17, 9:43 PM
Unknown Object (File)
Mon, Sep 7, 11:12 AM
Unknown Object (File)
Mon, Sep 7, 1:58 AM
View All 39 Files
Subscribers
delphij
imp

Details

Reviewers
senguptaangshuman17_gmail.com
imp
markj
Commits
rGa43b61a1ba45: makefs: Allow "legacy" as a valid ZFS mountpoint
rG59d6422d6f21: makefs: Allow "legacy" as a valid ZFS mountpoint
Summary

Allow "legacy" alongside "none" as a valid value for the ZFS mountpoint
property, matching zfsprops(7).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75513
Build 72396: arc lint + arc unit

Event Timeline

jlduran created this revision.Aug 11 2026, 3:10 AM
Herald added subscribers: delphij, imp. · View Herald TranscriptAug 11 2026, 3:10 AM
jlduran requested review of this revision.Aug 11 2026, 3:10 AM
Harbormaster completed remote builds in B75513: Diff 183860.Aug 11 2026, 3:10 AM
jlduran added a reviewer: senguptaangshuman17_gmail.com.Aug 11 2026, 3:11 AM
jlduran added a comment.Aug 11 2026, 3:14 AM

We are still pondering if NanoBSD's /cfg partition, when using ZFS, should be legacy. At any rate, let's allow makefs(8) to create legacy mountpoints.

imp accepted this revision.Aug 11 2026, 3:47 AM
This revision is now accepted and ready to land.Aug 11 2026, 3:47 AM
imp added a reviewer: markj.Aug 11 2026, 6:21 PM
markj accepted this revision.Aug 11 2026, 6:31 PM
markj added inline comments.
usr.sbin/makefs/tests/makefs_zfs_tests.sh
688
jlduran added inline comments.Aug 11 2026, 6:37 PM
usr.sbin/makefs/tests/makefs_zfs_tests.sh
650

@markj I'll change this one as well. Thanks

Closed by commit rG59d6422d6f21: makefs: Allow "legacy" as a valid ZFS mountpoint (authored by jlduran). · Explain WhyAug 11 2026, 10:35 PM
This revision was automatically updated to reflect the committed changes.
jlduran added a commit: rG59d6422d6f21: makefs: Allow "legacy" as a valid ZFS mountpoint.
jlduran marked an inline comment as done.Aug 11 2026, 10:36 PM
jlduran added a commit: rGa43b61a1ba45: makefs: Allow "legacy" as a valid ZFS mountpoint.Aug 18 2026, 12:31 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
makefs/
tests/
39 lines
zfs/
5 lines

Diff 183860

View Options

usr.sbin/makefs/tests/makefs_zfs_tests.sh

Loading...
View Options

usr.sbin/makefs/zfs/dsl.c

Loading...