Page MenuHomeFreeBSD
Differential D58625

bhyve: Fix assignment of *niov2 in split_iov()
ClosedPublic
Actions

Authored by markj on Aug 3 2026, 4:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 30, 4:32 PM
Unknown Object (File)
Wed, Sep 30, 4:32 PM
Unknown Object (File)
Wed, Sep 30, 4:32 PM
Unknown Object (File)
Wed, Sep 30, 7:48 AM
Unknown Object (File)
Wed, Sep 30, 1:54 AM
Unknown Object (File)
Wed, Sep 23, 2:53 AM
Unknown Object (File)
Fri, Sep 11, 7:31 AM
Unknown Object (File)
Wed, Sep 9, 6:51 PM
View All 38 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
rosenfeld_grumpf.hope-2000.org
Group Reviewers
secteam
bhyve
Commits
rG4dc196233e40: bhyve: Fix assignment of *niov2 in split_iov()
Summary

niov2 returns the number of entries in the iovec starting at offset
"offset". Here we are unconditionally setting it to 1, which of course
isn't right.

Fixes: a28cf86c4171 ("bhyve/virtio: Rework iovec handling functions for efficiency and clarity")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75350
Build 72233: arc lint + arc unit

Event Timeline

markj created this revision.Aug 3 2026, 4:00 PM
Herald added a reviewer: bhyve. · View Herald TranscriptAug 3 2026, 4:00 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
markj requested review of this revision.Aug 3 2026, 4:00 PM
markj added a reviewer: rosenfeld_grumpf.hope-2000.org.Aug 3 2026, 4:00 PM
Harbormaster completed remote builds in B75350: Diff 183320.Aug 3 2026, 4:00 PM
rosenfeld_grumpf.hope-2000.org added a comment.Aug 3 2026, 5:06 PM

Not sure how to give a proper +1 here. Do I need special permissions for that?

Anyway, LGTM.

markj added a comment.Aug 3 2026, 6:12 PM
In D58625#1345242, @rosenfeld_grumpf.hope-2000.org wrote:

Not sure how to give a proper +1 here. Do I need special permissions for that?

I don't think so, at the bottom of the webui there should be a dropdown menu with an "Accept Revision" action.

Anyway, LGTM.

rosenfeld_grumpf.hope-2000.org accepted this revision.Aug 3 2026, 6:40 PM

Indeed, there it is.

This revision is now accepted and ready to land.Aug 3 2026, 6:40 PM
Closed by commit rG4dc196233e40: bhyve: Fix assignment of *niov2 in split_iov() (authored by markj). · Explain WhyAug 5 2026, 7:03 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG4dc196233e40: bhyve: Fix assignment of *niov2 in split_iov().

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
2 lines

Diff 183320

View Options

usr.sbin/bhyve/iov.c

Loading...