bhyve: Fix assignment of *niov2 in split_iov()
ClosedPublic
Actions

Authored by markj on Mon, Aug 3, 4:00 PM.

Details

Reviewers

rosenfeld_grumpf.hope-2000.org

Group Reviewers

secteam
bhyve

Commits

rG4dc196233e40: bhyve: Fix assignment of *niov2 in split_iov()

Summary

niov2 returns the number of entries in the iovec starting at offset
"offset". Here we are unconditionally setting it to 1, which of course
isn't right.

Fixes: a28cf86c4171 ("bhyve/virtio: Rework iovec handling functions for efficiency and clarity")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mon, Aug 3, 4:00 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMon, Aug 3, 4:00 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

markj requested review of this revision.Mon, Aug 3, 4:00 PM

markj added a reviewer: rosenfeld_grumpf.hope-2000.org.Mon, Aug 3, 4:00 PM

Harbormaster completed remote builds in B75350: Diff 183320.Mon, Aug 3, 4:00 PM

Not sure how to give a proper +1 here. Do I need special permissions for that?

Anyway, LGTM.

In D58625#1345242, @rosenfeld_grumpf.hope-2000.org wrote:

Not sure how to give a proper +1 here. Do I need special permissions for that?

I don't think so, at the bottom of the webui there should be a dropdown menu with an "Accept Revision" action.

Anyway, LGTM.

Indeed, there it is.

This revision is now accepted and ready to land.Mon, Aug 3, 6:40 PM

Closed by commit rG4dc196233e40: bhyve: Fix assignment of *niov2 in split_iov() (authored by markj). · Explain WhyWed, Aug 5, 7:03 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG4dc196233e40: bhyve: Fix assignment of *niov2 in split_iov().

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

iov.c

2 lines

Diff 183488

View Options

bhyve: Fix assignment of *niov2 in split_iov()ClosedPublicActions