Page MenuHomeFreeBSD
Differential D58554

ppp: Reject invalid endpoint discriminator options
ClosedPublic
Actions

Authored by markj on Jul 30 2026, 3:03 PM.
Tags
None
Referenced Files
F169587522: D58554.id183154.diff
Wed, Sep 2, 12:08 AM
F169558553: D58554.diff
Tue, Sep 1, 10:16 PM
F169523390: D58554.diff
Tue, Sep 1, 7:40 PM
Unknown Object (File)
Sun, Aug 30, 6:08 PM
Unknown Object (File)
Sun, Aug 30, 6:03 PM
Unknown Object (File)
Wed, Aug 26, 12:49 AM
Unknown Object (File)
Tue, Aug 25, 1:08 AM
Unknown Object (File)
Sun, Aug 23, 8:40 AM
View All 49 Files
Subscribers
imp

Details

Reviewers
jhb
emaste
Group Reviewers
secteam
Commits
rG428f4b194cef: ppp: Reject invalid endpoint discriminator options
rG3e5e24f16eb1: ppp: Reject invalid endpoint discriminator options
rG7b0db357359a: ppp: Reject invalid endpoint discriminator options
rG10dd09ca4c77: ppp: Reject invalid endpoint discriminator options
rG542c98fba386: ppp: Reject invalid endpoint discriminator options
rG30b4bdd451ad: ppp: Reject invalid endpoint discriminator options
rGb9d07a430822: ppp: Reject invalid endpoint discriminator options
Summary

Per RFC1717 section 5.1.3, the option length must be at least three.
Processing an undersized option would trigger a large out-of-bounds
write.

PR: 271910
Reported by: Robert Morris
Reported by: Décio Brandão (0xDBJ)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75293
Build 72176: arc lint + arc unit

Event Timeline

markj created this revision.Jul 30 2026, 3:03 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 30 2026, 3:03 PM
markj requested review of this revision.Jul 30 2026, 3:03 PM
Harbormaster completed remote builds in B75293: Diff 183110.Jul 30 2026, 3:03 PM
markj added a child revision: D58555: ppp: Avoid overflow when formatting endpoint discriminator options.Jul 30 2026, 3:04 PM
emaste accepted this revision.Jul 30 2026, 4:02 PM
This revision is now accepted and ready to land.Jul 30 2026, 4:02 PM
Closed by commit rGb9d07a430822: ppp: Reject invalid endpoint discriminator options (authored by markj). · Explain WhyJul 31 2026, 1:30 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGb9d07a430822: ppp: Reject invalid endpoint discriminator options.
markj added a commit: rG30b4bdd451ad: ppp: Reject invalid endpoint discriminator options.Fri, Aug 7, 12:42 PM
markj added a commit: rG542c98fba386: ppp: Reject invalid endpoint discriminator options.Fri, Aug 7, 12:51 PM
cperciva added a commit: rG10dd09ca4c77: ppp: Reject invalid endpoint discriminator options.Thu, Aug 20, 5:54 PM
Herald added a reviewer: scheduler. · View Herald TranscriptThu, Aug 20, 5:54 PM
lwhsu removed a reviewer: scheduler.Thu, Aug 20, 8:12 PM
markj added a commit: rG7b0db357359a: ppp: Reject invalid endpoint discriminator options.Tue, Aug 25, 4:01 PM
markj added a commit: rG3e5e24f16eb1: ppp: Reject invalid endpoint discriminator options.
markj added a commit: rG428f4b194cef: ppp: Reject invalid endpoint discriminator options.

Revision Contents
Changeset List

PathSize
usr.sbin/
ppp/
6 lines

Diff 183110

View Options

usr.sbin/ppp/lcp.c

Loading...