Each byte of the address is represented by a pair of characters, so we
should be multiplying len by 2 when figuring out how much buffer space
we have.
Details
Details
- Reviewers
jhb - Group Reviewers
secteam - Commits
- rG23deefa40b8d: ppp: Avoid overflow when formatting endpoint discriminator options
rG0cd984b41c2f: ppp: Avoid overflow when formatting endpoint discriminator options
rG561c1fc29b52: ppp: Avoid overflow when formatting endpoint discriminator options
rG281fb7d8a20b: ppp: Avoid overflow when formatting endpoint discriminator options
rG607c41d8f869: ppp: Avoid overflow when formatting endpoint discriminator options
rG78dfadaa0618: ppp: Avoid overflow when formatting endpoint discriminator options
rGe004ff15f87e: ppp: Avoid overflow when formatting endpoint discriminator options
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Cast bytes to unsigned char, otherwise a negative byte will be sign
extended and occupy more than two bytes of the buffer.