Page MenuHomeFreeBSD

routing: Remove unused rib_head members
ClosedPublic

Authored by pouria on Wed, Jul 29, 5:57 PM.
Tags
None
Referenced Files
F164913067: D58537.id183067.diff
Tue, Aug 4, 6:56 PM
Unknown Object (File)
Tue, Aug 4, 5:15 AM
Unknown Object (File)
Sun, Aug 2, 5:01 AM
Unknown Object (File)
Sun, Aug 2, 3:15 AM
Unknown Object (File)
Sun, Aug 2, 3:04 AM
Unknown Object (File)
Sun, Aug 2, 2:15 AM
Unknown Object (File)
Sun, Aug 2, 12:44 AM
Unknown Object (File)
Sat, Aug 1, 12:54 PM
Subscribers

Details

Summary

Remove unused rnh_multipath and rib_algo_fixed members.
While here, convert rib_dying and rib_algo_init from uint32_t to bool.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75270
Build 72153: arc lint + arc unit

Event Timeline

sys/net/route/route_var.h
69–70

Practically a bool occupies one byte. Not sure if there is a standard about that, though. So change as is will take 2 bytes. But if you code it as bit fields, they are getting packed. With suggested change two bools will take only one byte and later you can add 6 more bools in the same manner without growing the structure.

I actually really would like us officially to promote this style instead of using pre-processor defines for flags.

pouria marked an inline comment as done.

Address @glebius comment

This revision is now accepted and ready to land.Wed, Jul 29, 11:10 PM
This revision was automatically updated to reflect the committed changes.