Differential D58424

tcp_hostcache: ensure expire and prune values stay consistent with each other
Needs ReviewPublic
Actions

Authored by rscheff on Thu, Jul 23, 7:09 PM.

Tags

None

Referenced Files

	F163889409: D58424.diff
	Sun, Jul 26, 10:37 PM

Subscribers

Details

Reviewers

tuexen
dch
glebius
peter.lei_ieee.org

Group Reviewers

Summary

While getting more information around PR296474 it was found that existing
configurations can end up with unexpectedly long pruning intervals, which
defy an explict short expire timeout of the hostcache entries.

When configuring the expire timeout to something short, make sure that the
prune time runs at least at that interval. Similarly, when adjusting the
prune interval up, ensure the expire timeout reflect that expected minimum
time also.

MFC after 3 days alongside D58360

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 75057
Build 71940: arc lint + arc unit

Event Timeline

rscheff created this revision.Thu, Jul 23, 7:09 PM

Herald added a reviewer: transport. · View Herald TranscriptThu, Jul 23, 7:09 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

rscheff requested review of this revision.Thu, Jul 23, 7:09 PM

Harbormaster completed remote builds in B75057: Diff 182554.Thu, Jul 23, 7:09 PM

pouria added a subscriber: pouria.Thu, Jul 23, 7:19 PM

pouria added inline comments.

sys/netinet/tcp_hostcache.c
184	Can we use UINT here?
636
638–639	Maybe use u_int?

also restart the callout so the next pruning will occur at the expected time

Harbormaster completed remote builds in B75131: Diff 182706.Sat, Jul 25, 8:04 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_hostcache.c

52 lines

Diff 182554

sys/netinet/tcp_hostcache.c

Loading...