Page MenuHomeFreeBSD
Differential D7167

Fail buildkernel if KERNCONF file not found.
ClosedPublic
Actions

Authored by cy on Jul 9 2016, 7:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 21, 2:13 AM
Unknown Object (File)
Fri, Nov 21, 2:12 AM
Unknown Object (File)
Fri, Nov 21, 2:12 AM
Unknown Object (File)
Fri, Nov 21, 2:09 AM
Unknown Object (File)
Sat, Nov 1, 8:03 AM
Unknown Object (File)
Sat, Nov 1, 2:01 AM
Unknown Object (File)
Sat, Nov 1, 2:01 AM
Unknown Object (File)
Sat, Nov 1, 2:01 AM
View All 89 Files
Subscribers
emaste

Details

Reviewers
gjb
ngie
delphij
glebius
imp
bdrewery
Commits
rS326833: MFC r324248:
rS324248: When building multiple kernels using KERNCONF, non-existent KERNCONF
rS324246: When building multiple kernels using KERNCONF, non-existent KERNCONF
rS302866: Document that missing KERNCONF files will now cause buildkernel to fail.
rS302865: When building multiple kernels using KERNCONF, non-existent KERNCONF
Summary

When building multiple kernels as in below:

KERNCONF?= BREAK PROD
INSTALLKERNEL?= BREAK

Should one of the kernel config files not exist, there is no indication
of error. Make buildkernel builds successfully. This patch causes
buildkernel to fail if any of the KERNCONF files is missing.

Test Plan

slippy$ make -DKQDTRACE buildkernel
make[1]: "/export/home/cy/freebsd/svn2/current/Makefile.inc1" line 1144: Missing KERNCONF /export/home/cy/freebsd/svn2/current/sys/amd64/conf/PROD

  • Error code 1

Stop.
make: stopped in /export/home/cy/freebsd/svn2/current
slippy$

make.conf contains the following,

.ifdef KQDTRACE
KERNCONF?= BREAK PROD
INSTALLKERNEL?= BREAK
ALL_MODLES= yes
.endif

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4467
Build 4518: arc lint + arc unit

Event Timeline

cy updated this revision to Diff 18242.Jul 9 2016, 7:38 PM
cy retitled this revision from to Fail buildkernel if KERNCONF file not found..
cy updated this object.
cy edited the test plan for this revision. (Show Details)
cy added reviewers: glebius, ngie, bdrewery, imp, gjb, delphij.
Herald added a subscriber: emaste. · View Herald TranscriptJul 9 2016, 7:38 PM
ngie edited edge metadata.Jul 11 2016, 4:03 PM

This seems ok to me at least. Have you tested out this change with make tinderbox?

This will definitely deserve Relnotes as it could break someone's usecase.

cy added a comment.Jul 11 2016, 11:32 PM

Tinderbox build passed.

Relnotes and UPDATING, for sure.

Closed by commit rS302865: When building multiple kernels using KERNCONF, non-existent KERNCONF (authored by cy). · Explain WhyJul 15 2016, 4:43 AM
This revision was automatically updated to reflect the committed changes.
cy mentioned this in rS302865: When building multiple kernels using KERNCONF, non-existent KERNCONF.
cy mentioned this in rS302866: Document that missing KERNCONF files will now cause buildkernel to fail..Jul 15 2016, 4:51 AM
cy mentioned this in rS324246: When building multiple kernels using KERNCONF, non-existent KERNCONF.Oct 4 2017, 3:24 AM
cy mentioned this in rS324248: When building multiple kernels using KERNCONF, non-existent KERNCONF.Oct 4 2017, 3:40 AM

Revision Contents
Changeset List

PathSize
2 lines

Diff 18242

View Options

Makefile.inc1

Loading...