ClosedPublic
Actions

Authored by dumbbell on Jun 14 2026, 9:07 AM.

Details

Reviewers

bz
emaste

Group Reviewers

linuxkpi

Commits

rG45e00486d695: linuxkpi: Include <linux/notifier.h> and <linux/device.h> from <linux/pm_qos.h>

Summary

The i915 DRM driver started to depend on the bool type implicitly imported through these headers in Linux 6.13.

The previous fix committed in 67df313015906d84d90df8e37795885e81cf8da5 did not reproduce the same includes as Linux. This may have led to other missing implicit definitions later.

This is part of the update of DRM drivers to Linux 6.13.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dumbbell created this revision.Jun 14 2026, 9:07 AM

Herald added subscribers: emaste, imp. · View Herald TranscriptJun 14 2026, 9:07 AM

dumbbell requested review of this revision.Jun 14 2026, 9:07 AM

dumbbell edited the summary of this revision. (Show Details)

dumbbell added a child revision: D57571: linuxkpi: Add missing includes leading to <linux/kconfig.h>.Jun 14 2026, 9:32 AM

dumbbell added a parent revision: D57463: LinuxKPI: Create pm_runtime_resume_and_get function, used by new versions of amdgpu.

emaste added inline comments.Jun 20 2026, 1:47 PM

sys/compat/linuxkpi/common/include/linux/pm_qos.h
31–33	why have this commented out?

@emaste had a comment for you here. Can you update?

This revision now requires changes to proceed.Jul 13 2026, 2:20 PM

Address comment from @emaste by uncommenting the include of <linux/plist.h> and adding it as a dummy header.

OK. It seemed strange to have a commented header that doesn't exist. IMO just dropping the #include would be OK but no objection to an empty file that we can eventually populate if something starts depending on it.

bz accepted this revision.Jul 27 2026, 8:20 PM

This revision is now accepted and ready to land.Jul 27 2026, 8:20 PM

Closed by commit rG45e00486d695: linuxkpi: Include <linux/notifier.h> and <linux/device.h> from <linux/pm_qos.h> (authored by dumbbell). · Explain WhySat, Aug 15, 6:29 PM

This revision was automatically updated to reflect the committed changes.

dumbbell added a commit: rG45e00486d695: linuxkpi: Include <linux/notifier.h> and <linux/device.h> from <linux/pm_qos.h>.