Page MenuHomeFreeBSD

linuxkpi: Include <linux/notifier.h> and <linux/device.h> from <linux/pm_qos.h>
ClosedPublic

Authored by dumbbell on Jun 14 2026, 9:07 AM.
Tags
None
Referenced Files
F167972250: D57570.id184105.diff
Tue, Aug 25, 4:59 PM
F167892720: D57570.id179713.diff
Tue, Aug 25, 7:21 AM
Unknown Object (File)
Sun, Aug 23, 5:17 PM
Unknown Object (File)
Sun, Aug 23, 4:52 PM
Unknown Object (File)
Thu, Aug 20, 6:26 PM
Unknown Object (File)
Wed, Aug 19, 11:27 PM
Unknown Object (File)
Wed, Aug 19, 2:17 PM
Unknown Object (File)
Wed, Aug 19, 3:39 AM
Subscribers

Details

Summary

The i915 DRM driver started to depend on the bool type implicitly imported through these headers in Linux 6.13.

The previous fix committed in 67df313015906d84d90df8e37795885e81cf8da5 did not reproduce the same includes as Linux. This may have led to other missing implicit definitions later.

This is part of the update of DRM drivers to Linux 6.13.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dumbbell edited the summary of this revision. (Show Details)
sys/compat/linuxkpi/common/include/linux/pm_qos.h
31–33

why have this commented out?

bz requested changes to this revision.Jul 13 2026, 2:20 PM
bz added a subscriber: bz.

@emaste had a comment for you here. Can you update?

This revision now requires changes to proceed.Jul 13 2026, 2:20 PM

Address comment from @emaste by uncommenting the include of <linux/plist.h> and adding it as a dummy header.

OK. It seemed strange to have a commented header that doesn't exist. IMO just dropping the #include would be OK but no objection to an empty file that we can eventually populate if something starts depending on it.

This revision is now accepted and ready to land.Mon, Jul 27, 8:20 PM