Page MenuHomeFreeBSD
Differential D57570

linuxkpi: Include <linux/notifier.h> and <linux/device.h> from <linux/pm_qos.h>
AcceptedPublic
Actions

Authored by dumbbell on Jun 14 2026, 9:07 AM.
Tags
None
Referenced Files
F164545316: D57570.id179713.diff
Sun, Aug 2, 12:46 AM
F164514684: D57570.id.diff
Sat, Aug 1, 3:40 PM
Unknown Object (File)
Sat, Aug 1, 6:34 AM
Unknown Object (File)
Sat, Aug 1, 5:47 AM
Unknown Object (File)
Sat, Aug 1, 4:38 AM
Unknown Object (File)
Fri, Jul 31, 7:14 AM
Unknown Object (File)
Thu, Jul 30, 8:33 PM
Unknown Object (File)
Wed, Jul 29, 5:40 AM
View All 27 Files
Subscribers
bz
emaste
imp

Details

Reviewers
bz
emaste
Group Reviewers
linuxkpi
Summary

The i915 DRM driver started to depend on the bool type implicitly imported through these headers in Linux 6.13.

The previous fix committed in 67df313015906d84d90df8e37795885e81cf8da5 did not reproduce the same includes as Linux. This may have led to other missing implicit definitions later.

This is part of the update of DRM drivers to Linux 6.13.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dumbbell created this revision.Jun 14 2026, 9:07 AM
Herald added subscribers: emaste, imp. · View Herald TranscriptJun 14 2026, 9:07 AM
dumbbell requested review of this revision.Jun 14 2026, 9:07 AM
dumbbell edited the summary of this revision. (Show Details)
dumbbell added a child revision: D57571: linuxkpi: Add missing includes leading to <linux/kconfig.h>.Jun 14 2026, 9:32 AM
dumbbell added a parent revision: D57463: LinuxKPI: Create pm_runtime_resume_and_get function, used by new versions of amdgpu.
emaste added inline comments.Jun 20 2026, 1:47 PM
sys/compat/linuxkpi/common/include/linux/pm_qos.h
31–33

why have this commented out?

bz requested changes to this revision.Mon, Jul 13, 2:20 PM
bz added a subscriber: bz.

@emaste had a comment for you here. Can you update?

This revision now requires changes to proceed.Mon, Jul 13, 2:20 PM
dumbbell updated this revision to Diff 181954.Tue, Jul 14, 10:01 AM

Address comment from @emaste by uncommenting the include of <linux/plist.h> and adding it as a dummy header.

emaste accepted this revision.Mon, Jul 27, 7:06 PM

OK. It seemed strange to have a commented header that doesn't exist. IMO just dropping the #include would be OK but no objection to an empty file that we can eventually populate if something starts depending on it.

bz accepted this revision.Mon, Jul 27, 8:20 PM
This revision is now accepted and ready to land.Mon, Jul 27, 8:20 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
4 lines
dummy/
include/
linux/

Diff 181954

View Options

sys/compat/linuxkpi/common/include/linux/pm_qos.h

Loading...
View Options

sys/compat/linuxkpi/dummy/include/linux/plist.h

Loading...