Page MenuHomeFreeBSD
Differential D57702

linuxkpi: Add <linux/cgroup_dmem.h>
ClosedPublic
Actions

Authored by dumbbell on Sat, Jun 20, 12:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 12, 1:57 AM
Unknown Object (File)
Wed, Jul 8, 7:21 AM
Unknown Object (File)
Tue, Jul 7, 1:15 AM
Unknown Object (File)
Mon, Jul 6, 10:26 AM
Unknown Object (File)
Mon, Jul 6, 12:53 AM
Unknown Object (File)
Sun, Jul 5, 9:19 PM
Unknown Object (File)
Sun, Jul 5, 4:44 AM
Unknown Object (File)
Sat, Jul 4, 9:39 PM
View All 21 Files
Subscribers
bz
emaste
imp

Details

Reviewers
emaste
Group Reviewers
linuxkpi
Commits
rGb55cc81fcf97: linuxkpi: Add <linux/cgroup_dmem.h>
Summary

In this header, we declare empty stubs for all functions, as if CONFIG_CGROUP_DMEM was disabled is Linux.

The DRM TTM memory manager started to use this in Linux 6.14.

This is part of the update of DRM drivers to Linux 6.14.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dumbbell created this revision.Sat, Jun 20, 12:04 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptSat, Jun 20, 12:04 PM
dumbbell requested review of this revision.Sat, Jun 20, 12:04 PM
dumbbell added a parent revision: D57701: linuxkpi: Add `kthread_run_worker()`.Sat, Jun 20, 12:07 PM
dumbbell added a child revision: D57703: linuxkpi: Define `ULL()`.
emaste accepted this revision.Sat, Jun 20, 1:45 PM
This revision is now accepted and ready to land.Sat, Jun 20, 1:45 PM
Closed by commit rGb55cc81fcf97: linuxkpi: Add <linux/cgroup_dmem.h> (authored by dumbbell). · Explain WhyWed, Jun 24, 4:48 PM
This revision was automatically updated to reflect the committed changes.
dumbbell added a commit: rGb55cc81fcf97: linuxkpi: Add <linux/cgroup_dmem.h>.
bz added a subscriber: bz.Sat, Jul 11, 1:50 PM

Post-commit review: the upstream file is MIT. We may consider just pulling that in (in parts) and reflect that in the license?

sys/compat/linuxkpi/common/include/linux/cgroup_dmem.h
32

I know upstream is doing that but either we should assert that ret-pool is not NULL or put it behind a if as well. I don't mind if Linux blows up on a caller error but I'd rather we'd not.

bz added a comment.Sat, Jul 11, 1:51 PM

P2S: also pr_debug("TODO: %s\n", func); for all the empty functions?

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
58 lines

Diff 180550

View Options

sys/compat/linuxkpi/common/include/linux/cgroup_dmem.h

Loading...