thunderbolt: Support writing to router config space
Needs ReviewPublic
Actions

Authored by obiwac on Mon, Jul 13, 8:47 AM.

Tags

None

Referenced Files

	F164459703: D58209.diff
	Sat, Aug 1, 5:06 AM

	Unknown Object (File)
	Fri, Jul 24, 7:43 AM

	Unknown Object (File)
	Wed, Jul 22, 9:36 AM

	Unknown Object (File)
	Tue, Jul 21, 9:15 PM

	Unknown Object (File)
	Mon, Jul 20, 9:00 PM

	Unknown Object (File)
	Mon, Jul 20, 11:20 AM

	Unknown Object (File)
	Mon, Jul 20, 2:41 AM

	Unknown Object (File)
	Sun, Jul 19, 1:45 AM

View All 13 Files

Subscribers

imp

Details

Reviewers

olce
jhb
ngie

Summary

Not to be confused with PCI config space; we write to a router's config
space by preparing a write command and enqueuing it on our NHI's
transmit ring.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 74763
Build 71646: arc lint + arc unit

Event Timeline

obiwac created this revision.Mon, Jul 13, 8:47 AM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jul 13, 8:47 AM

obiwac requested review of this revision.Mon, Jul 13, 8:47 AM

Harbormaster completed remote builds in B74763: Diff 181891.Mon, Jul 13, 8:47 AM

ngie added inline comments.Mon, Jul 13, 10:31 PM

sys/dev/thunderbolt/router.c
643	`size_t` instead of `int` seems more appropropriate, but I see that this type is passed through a bunch of callers.
651–659	Would you please replace `4` with a more usable constant / reference to some documentation that describes where this constraint is defined (I realize `router_prepare_read` needs similar treatment)?
sys/dev/thunderbolt/tbcfg_reg.h
67	Why remove this comment?