Page MenuHomeFreeBSD
Differential D57960

sysutils/dpv: New port
ClosedPublic
Actions

Authored by des on Mon, Jun 29, 11:47 PM.
Tags
None
Referenced Files
F161446264: D57960.id181097.diff
Fri, Jul 3, 9:01 PM
F161445438: D57960.id181092.diff
Fri, Jul 3, 8:47 PM
F161408804: D57960.id181092.diff
Fri, Jul 3, 12:34 PM
Unknown Object (File)
Thu, Jul 2, 10:09 PM
Unknown Object (File)
Thu, Jul 2, 9:23 PM
Unknown Object (File)
Thu, Jul 2, 11:11 AM
Unknown Object (File)
Thu, Jul 2, 11:11 AM
Unknown Object (File)
Thu, Jul 2, 11:11 AM
View All Files
Subscribers
arrowd
fuz

Details

Reviewers
dteske
fuz
Commits
R11:278661a01cd4: sysutils/dpv: New port

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74424
Build 71307: arc lint + arc unit

Event Timeline

des requested review of this revision.Mon, Jun 29, 11:47 PM
des created this revision.
Harbormaster completed remote builds in B74399: Diff 180960.Mon, Jun 29, 11:47 PM
des added a parent revision: D57959: devel/libdpv: New port.Mon, Jun 29, 11:47 PM
fuz added a subscriber: fuz.Tue, Jun 30, 1:02 AM
fuz added inline comments.
sysutils/dpv/Makefile
19

GH_PROJECT defaults to PORTNAME and can/should be omitted.

21

Are you sure this line is needed?

27

This needs to go further up, below LICENSE.

fuz mentioned this in D57959: devel/libdpv: New port.Tue, Jun 30, 1:04 AM
fuz mentioned this in D57958: devel/libfigpar: New port.
des marked an inline comment as done.Tue, Jun 30, 7:36 AM
des added inline comments.
sysutils/dpv/Makefile
19

I am trying to keep the three ports as similar as possible.

21

I thought it was, but the problem must have been somewhere else.

27

Not according to portlint, but ok.

des updated this revision to Diff 180970.Tue, Jun 30, 7:37 AM
des marked an inline comment as done.

rf

Harbormaster completed remote builds in B74404: Diff 180970.Tue, Jun 30, 7:37 AM
arrowd added a subscriber: arrowd.Tue, Jun 30, 7:41 AM
arrowd added inline comments.
sysutils/dpv/Makefile
24

This can be probably simplified to WRKSRC_SUBDIR= usr.bin/dpv

fuz added a comment.Tue, Jun 30, 9:10 AM

LGTM once @arrowd's suggestion is applied.

sysutils/dpv/Makefile
27

Portlint seems to be wrong here (cf. § 15.5 Porter's Handbook).

des updated this revision to Diff 181092.Tue, Jun 30, 5:52 PM

rf

Harbormaster completed remote builds in B74419: Diff 181092.Tue, Jun 30, 5:52 PM
fuz added a comment.Tue, Jun 30, 5:55 PM

LIB_DEPENDS goes before USES (sorry for not mentioning it earlier).
Rest looks ok.

des updated this revision to Diff 181095.Tue, Jun 30, 6:01 PM

rf

Harbormaster completed remote builds in B74422: Diff 181095.Tue, Jun 30, 6:01 PM
des updated this revision to Diff 181097.Tue, Jun 30, 6:02 PM

rf

Harbormaster completed remote builds in B74424: Diff 181097.Tue, Jun 30, 6:02 PM
des marked 3 inline comments as done.Tue, Jun 30, 6:04 PM
fuz accepted this revision.Tue, Jun 30, 6:49 PM
This revision is now accepted and ready to land.Tue, Jun 30, 6:49 PM
Closed by commit R11:278661a01cd4: sysutils/dpv: New port (authored by des). · Explain WhyTue, Jun 30, 6:57 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: R11:278661a01cd4: sysutils/dpv: New port.

Revision Contents
Changeset List

PathSize
sysutils/
1 line
dpv/
26 lines
3 lines
3 lines

Diff 181097

View Options

sysutils/Makefile

Loading...
View Options

sysutils/dpv/Makefile

Loading...
View Options

sysutils/dpv/distinfo

Loading...
View Options

sysutils/dpv/pkg-descr

Loading...