Page MenuHomeFreeBSD

sysutils/dpv: New port
ClosedPublic

Authored by des on Mon, Jun 29, 11:47 PM.
Tags
None
Referenced Files
F161333737: D57960.diff
Thu, Jul 2, 10:09 PM
F161330106: D57960.diff
Thu, Jul 2, 9:23 PM
F161286036: D57960.diff
Thu, Jul 2, 11:11 AM
F161286035: D57960.diff
Thu, Jul 2, 11:11 AM
F161286034: D57960.diff
Thu, Jul 2, 11:11 AM
F161286033: D57960.diff
Thu, Jul 2, 11:11 AM
F161286032: D57960.diff
Thu, Jul 2, 11:11 AM
F161286022: D57960.diff
Thu, Jul 2, 11:10 AM
Subscribers

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Mon, Jun 29, 11:47 PM
des created this revision.
fuz added inline comments.
sysutils/dpv/Makefile
19

GH_PROJECT defaults to PORTNAME and can/should be omitted.

21

Are you sure this line is needed?

27

This needs to go further up, below LICENSE.

des marked an inline comment as done.Tue, Jun 30, 7:36 AM
des added inline comments.
sysutils/dpv/Makefile
19

I am trying to keep the three ports as similar as possible.

21

I thought it was, but the problem must have been somewhere else.

27

Not according to portlint, but ok.

des marked an inline comment as done.

rf

arrowd added inline comments.
sysutils/dpv/Makefile
24

This can be probably simplified to WRKSRC_SUBDIR= usr.bin/dpv

LGTM once @arrowd's suggestion is applied.

sysutils/dpv/Makefile
27

Portlint seems to be wrong here (cf. § 15.5 Porter's Handbook).

LIB_DEPENDS goes before USES (sorry for not mentioning it earlier).
Rest looks ok.

des marked 3 inline comments as done.Tue, Jun 30, 6:04 PM
This revision is now accepted and ready to land.Tue, Jun 30, 6:49 PM
This revision was automatically updated to reflect the committed changes.