Page MenuHomeFreeBSD
Differential D57959

devel/libdpv: New port
ClosedPublic
Actions

Authored by des on Mon, Jun 29, 11:47 PM.
Tags
None
Referenced Files
F161767313: D57959.id180959.diff
Mon, Jul 6, 4:14 PM
F161742714: D57959.id.diff
Mon, Jul 6, 11:05 AM
F161741301: D57959.id181091.diff
Mon, Jul 6, 10:44 AM
F161705526: D57959.id181096.diff
Mon, Jul 6, 3:06 AM
F161697566: D57959.diff
Mon, Jul 6, 1:15 AM
F161696207: D57959.id181099.diff
Mon, Jul 6, 12:57 AM
F161682358: D57959.id181091.diff
Sun, Jul 5, 10:14 PM
F161682136: D57959.id181091.diff
Sun, Jul 5, 10:11 PM
View All Files
Subscribers
arrowd
fuz

Details

Reviewers
dteske
fuz
Commits
R11:f6a8a826d2ad: devel/libdpv: New port

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Mon, Jun 29, 11:47 PM
des created this revision.
Harbormaster completed remote builds in B74398: Diff 180959.Mon, Jun 29, 11:47 PM
des added a parent revision: D57958: devel/libfigpar: New port.Mon, Jun 29, 11:47 PM
des added a child revision: D57960: sysutils/dpv: New port.
fuz added a subscriber: fuz.Tue, Jun 30, 1:04 AM

See my review on D57960; the same issues apply.

des updated this revision to Diff 180969.Tue, Jun 30, 7:37 AM

rf

Harbormaster completed remote builds in B74403: Diff 180969.Tue, Jun 30, 7:37 AM
arrowd added a subscriber: arrowd.Tue, Jun 30, 7:45 AM
arrowd added inline comments.
devel/libdpv/Makefile
11

Only 14 has? You might want to add IGNORE_FreeBSD_15 and IGNORE_FreeBSD_16

16

LIB_DEPENDS should be placed before USES.

des updated this revision to Diff 181091.Tue, Jun 30, 5:52 PM

rf

Harbormaster completed remote builds in B74418: Diff 181091.Tue, Jun 30, 5:52 PM
fuz added a comment.Tue, Jun 30, 5:54 PM

LIB_DEPENDS needs to go before USES, still.

des updated this revision to Diff 181094.Tue, Jun 30, 6:01 PM

rf

Harbormaster completed remote builds in B74421: Diff 181094.Tue, Jun 30, 6:01 PM
des updated this revision to Diff 181096.Tue, Jun 30, 6:01 PM

rf

Harbormaster completed remote builds in B74423: Diff 181096.Tue, Jun 30, 6:02 PM
des marked 2 inline comments as done.Tue, Jun 30, 6:04 PM
des added inline comments.
devel/libdpv/Makefile
11

no, see 38981026e703

des marked an inline comment as done.Tue, Jun 30, 6:04 PM
fuz accepted this revision.Tue, Jun 30, 6:49 PM
This revision is now accepted and ready to land.Tue, Jun 30, 6:49 PM
Closed by commit R11:f6a8a826d2ad: devel/libdpv: New port (authored by des). · Explain WhyTue, Jun 30, 6:57 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: R11:f6a8a826d2ad: devel/libdpv: New port.

Revision Contents
Changeset List

PathSize
devel/
1 line
libdpv/
24 lines
3 lines
3 lines
6 lines

Diff 181099

View Options

devel/Makefile

Loading...
View Options

devel/libdpv/Makefile

Loading...
View Options

devel/libdpv/distinfo

Loading...
View Options

devel/libdpv/pkg-descr

Loading...
View Options

devel/libdpv/pkg-plist

Loading...