Page MenuHomeFreeBSD
Differential D57514

policy: Cross Repo Commit Policy
ClosedPublic
Actions

Authored by imp on Tue, Jun 9, 10:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 4, 10:31 AM
Unknown Object (File)
Thu, Jul 2, 11:34 PM
Unknown Object (File)
Thu, Jul 2, 4:19 AM
Unknown Object (File)
Thu, Jul 2, 4:12 AM
Unknown Object (File)
Wed, Jul 1, 10:55 PM
Unknown Object (File)
Wed, Jul 1, 6:57 PM
Unknown Object (File)
Wed, Jul 1, 6:57 PM
Unknown Object (File)
Wed, Jul 1, 6:20 PM
View All 48 Files
Subscribers
kevans
ziaee

Details

Reviewers
adrian
ziaee
0mp
kevans
glebius
Commits
R9:072353ccfc5d: policy: Cross Repo Commit Policy
Summary

Add Cross Repo Commit policy that was originally discussed in January
2023 by core, and ratified by the current core team on XXXX.

Sponsored by: Netflix

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73777
Build 70660: arc lint + arc unit

Event Timeline

imp requested review of this revision.Tue, Jun 9, 10:36 PM
imp created this revision.
Harbormaster completed remote builds in B73773: Diff 179524.Tue, Jun 9, 10:36 PM
imp updated this revision to Diff 179525.Tue, Jun 9, 10:37 PM

Add new file

Harbormaster completed remote builds in B73774: Diff 179525.Tue, Jun 9, 10:37 PM
imp updated this revision to Diff 179526.Tue, Jun 9, 10:39 PM

draft cross repo policy.

Harbormaster completed remote builds in B73775: Diff 179526.Tue, Jun 9, 10:39 PM
imp updated this revision to Diff 179528.Tue, Jun 9, 11:44 PM

Gemini made good readablity suggestions to my overly-verbose prose.

Harbormaster completed remote builds in B73777: Diff 179528.Tue, Jun 9, 11:44 PM
adrian accepted this revision.Tue, Jun 9, 11:48 PM
This revision is now accepted and ready to land.Tue, Jun 9, 11:48 PM
ziaee accepted this revision.Wed, Jun 10, 5:31 AM
ziaee added a subscriber: ziaee.
ziaee added inline comments.
website/content/en/internal/cross-repo-commits.adoc
17

Maybe?

0mp accepted this revision.Wed, Jun 10, 12:33 PM
imp added inline comments.Sun, Jun 14, 5:02 AM
website/content/en/internal/cross-repo-commits.adoc
17

Maybe Locked Areas: ports/Mk is a locked area, de-facto. It's special. Even build breakages there are off limits.

17

"Restricted Areas" might be even better.

19

I'm not completely sure about the ending here of 'followed by a case-by-case review'. Maybe 'followed by more review before recommit'? Sounds dorky, but maybe less dorky?

kevans accepted this revision.Fri, Jun 19, 1:20 PM
kevans added a subscriber: kevans.

This lines up with what I'd already been telling people despite the policy being unwritten. An interesting datapoint: most of the people I've told this is fine and wanted to commit to a different repo generally *wanted* review for even nearly-trivial changes, which I think is an interesting progression from our review culture just 5-10 years ago.

imp updated this revision to Diff 180050.Fri, Jun 19, 1:40 PM

Slight word smith

This revision now requires review to proceed.Fri, Jun 19, 1:40 PM
Harbormaster completed remote builds in B73994: Diff 180050.Fri, Jun 19, 1:40 PM
kevans accepted this revision.Fri, Jun 19, 1:41 PM
This revision is now accepted and ready to land.Fri, Jun 19, 1:41 PM
imp added inline comments.Fri, Jun 19, 1:43 PM
website/content/en/internal/cross-repo-commits.adoc
17

Now that I've thought about it, Stricter Rules likely is best.

adrian accepted this revision.Fri, Jun 19, 8:07 PM
glebius accepted this revision.Sun, Jun 21, 12:29 PM
Closed by commit R9:072353ccfc5d: policy: Cross Repo Commit Policy (authored by imp). · Explain WhyFri, Jun 26, 5:14 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: R9:072353ccfc5d: policy: Cross Repo Commit Policy.

Revision Contents
Changeset List

PathSize
website/
content/
en/
internal/
21 lines
1 line

Diff 179528

View Options

website/content/en/internal/cross-repo-commits.adoc

Loading...
View Options

website/content/en/internal/policies.adoc

Loading...