Differential D57514

policy: Cross Repo Commit Policy
ClosedPublic
Actions

Authored by imp on Tue, Jun 9, 10:36 PM.

Tags

None

Referenced Files

	F161150868: D57514.id179524.diff
	Wed, Jul 1, 12:37 AM

	F161106330: D57514.id179524.diff
	Tue, Jun 30, 2:45 PM

	F161106007: D57514.id179524.diff
	Tue, Jun 30, 2:41 PM

	F161103166: D57514.id179526.diff
	Tue, Jun 30, 2:10 PM

	F161102732: D57514.id179526.diff
	Tue, Jun 30, 2:06 PM

	Unknown Object (File)
	Tue, Jun 30, 5:21 AM

	Unknown Object (File)
	Tue, Jun 30, 5:18 AM

	Unknown Object (File)
	Tue, Jun 30, 2:10 AM

View All 40 Files

Subscribers

Details

Reviewers

adrian
ziaee
0mp
kevans
glebius

Commits

R9:072353ccfc5d: policy: Cross Repo Commit Policy

Summary

Add Cross Repo Commit policy that was originally discussed in January
2023 by core, and ratified by the current core team on XXXX.

Sponsored by: Netflix

Diff Detail

Repository

R9 FreeBSD doc repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73774
Build 70657: arc lint + arc unit

Event Timeline

imp requested review of this revision.Tue, Jun 9, 10:36 PM

imp created this revision.

Harbormaster completed remote builds in B73773: Diff 179524.Tue, Jun 9, 10:36 PM

Add new file

Harbormaster completed remote builds in B73774: Diff 179525.Tue, Jun 9, 10:37 PM

draft cross repo policy.

Harbormaster completed remote builds in B73775: Diff 179526.Tue, Jun 9, 10:39 PM

Gemini made good readablity suggestions to my overly-verbose prose.

Harbormaster completed remote builds in B73777: Diff 179528.Tue, Jun 9, 11:44 PM

adrian accepted this revision.Tue, Jun 9, 11:48 PM

This revision is now accepted and ready to land.Tue, Jun 9, 11:48 PM

ziaee accepted this revision.Wed, Jun 10, 5:31 AM

ziaee added a subscriber: ziaee.

ziaee added inline comments.

website/content/en/internal/cross-repo-commits.adoc
17 ↗	(On Diff #179528)	Maybe?

0mp accepted this revision.Wed, Jun 10, 12:33 PM

imp added inline comments.Sun, Jun 14, 5:02 AM

website/content/en/internal/cross-repo-commits.adoc
17 ↗	(On Diff #179528)	Maybe Locked Areas: ports/Mk is a locked area, de-facto. It's special. Even build breakages there are off limits.
17 ↗	(On Diff #179528)	"Restricted Areas" might be even better.
19 ↗	(On Diff #179528)	I'm not completely sure about the ending here of 'followed by a case-by-case review'. Maybe 'followed by more review before recommit'? Sounds dorky, but maybe less dorky?

This lines up with what I'd already been telling people despite the policy being unwritten. An interesting datapoint: most of the people I've told this is fine and wanted to commit to a different repo generally *wanted* review for even nearly-trivial changes, which I think is an interesting progression from our review culture just 5-10 years ago.

Slight word smith

This revision now requires review to proceed.Fri, Jun 19, 1:40 PM

Harbormaster completed remote builds in B73994: Diff 180050.Fri, Jun 19, 1:40 PM

kevans accepted this revision.Fri, Jun 19, 1:41 PM

This revision is now accepted and ready to land.Fri, Jun 19, 1:41 PM

imp added inline comments.Fri, Jun 19, 1:43 PM

website/content/en/internal/cross-repo-commits.adoc
17 ↗	(On Diff #179528)	Now that I've thought about it, Stricter Rules likely is best.

adrian accepted this revision.Fri, Jun 19, 8:07 PM

glebius accepted this revision.Sun, Jun 21, 12:29 PM

Closed by commit R9:072353ccfc5d: policy: Cross Repo Commit Policy (authored by imp). · Explain WhyFri, Jun 26, 5:14 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: R9:072353ccfc5d: policy: Cross Repo Commit Policy.

Revision Contents
Changeset List

Path

Size

website/

content/

en/

internal/

1 line

Diff 179525

website/content/en/internal/policies.adoc

Loading...