inpcb: a pcb may travel only from the wild hash to exact, not vice versa
ClosedPublic
Actions

Authored by glebius on May 26 2026, 4:06 AM.

Tags

None

Referenced Files

	F164951821: D57241.id178777.diff
	Wed, Aug 5, 2:29 AM

	F164909820: D57241.id178590.diff
	Tue, Aug 4, 6:08 PM

	Unknown Object (File)
	Tue, Aug 4, 3:49 AM

	Unknown Object (File)
	Thu, Jul 30, 11:15 PM

	Unknown Object (File)
	Tue, Jul 28, 11:12 PM

	Unknown Object (File)
	Sun, Jul 26, 4:15 PM

	Unknown Object (File)
	Sat, Jul 25, 8:47 AM

	Unknown Object (File)
	Wed, Jul 15, 7:23 AM

View All 38 Files

Subscribers

imp

melifaro

Details

Reviewers

markj

Group Reviewers

network

Commits

rGca91300c0749: inpcb: a pcb may travel only from the wild hash to exact, not vice versa

Summary

The only possible way to exercise in_pcbrehash() is to bind(2) and then
connect(2). The second branch was a dead code since fdb987bebddf.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73439
Build 70322: arc lint + arc unit

Event Timeline

glebius created this revision.May 26 2026, 4:06 AM

Herald added subscribers: melifaro, imp. · View Herald TranscriptMay 26 2026, 4:06 AM

glebius requested review of this revision.May 26 2026, 4:06 AM

Harbormaster completed remote builds in B73439: Diff 178590.May 26 2026, 4:06 AM

markj accepted this revision.May 26 2026, 2:15 PM

This revision is now accepted and ready to land.May 26 2026, 2:15 PM

Closed by commit rGca91300c0749: inpcb: a pcb may travel only from the wild hash to exact, not vice versa (authored by glebius). · Explain WhyMay 28 2026, 5:07 AM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGca91300c0749: inpcb: a pcb may travel only from the wild hash to exact, not vice versa.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_pcb.c

22 lines

Diff 178590

View Options

inpcb: a pcb may travel only from the wild hash to exact, not vice versaClosedPublicActions