tftp: Fix handling of port name or number
ClosedPublic
Actions

Authored by des on May 19 2026, 9:58 PM.

Details

Reviewers

Commits

rG12e8c16e3424: tftp: Fix handling of port name or number
rG8c11ec396445: tftp: Fix handling of port name or number
rG47e4571df158: tftp: Fix handling of port name or number

Summary

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73306
Build 70189: arc lint + arc unit

Event Timeline

des created this revision.May 19 2026, 9:58 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 19 2026, 9:58 PM

des requested review of this revision.May 19 2026, 9:58 PM

Harbormaster completed remote builds in B73245: Diff 178143.May 19 2026, 9:58 PM

des added a child revision: D57072: tftp: Replace fgets with getline.May 19 2026, 9:58 PM

des added a parent revision: D57071: tftp: Close files when we're done with them.

des mentioned this in D57072: tftp: Replace fgets with getline.

markj added inline comments.May 20 2026, 1:35 PM

usr.bin/tftp/tftp.c
85	recvfile() has the same code.

recvfile

Harbormaster completed remote builds in B73306: Diff 178305.May 21 2026, 9:42 AM

des marked an inline comment as done.May 21 2026, 9:42 AM

markj accepted this revision.May 21 2026, 2:17 PM

This revision is now accepted and ready to land.May 21 2026, 2:17 PM

Closed by commit rG47e4571df158: tftp: Fix handling of port name or number (authored by des). · Explain WhyMay 22 2026, 5:58 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG47e4571df158: tftp: Fix handling of port name or number.

des added a commit: rG8c11ec396445: tftp: Fix handling of port name or number.May 27 2026, 9:04 AM

des added a commit: rG12e8c16e3424: tftp: Fix handling of port name or number.

Revision Contents
Changeset List

Path

Size

usr.bin/

tftp/

main.c

7 lines

tftp.c

40 lines

Diff 178305

View Options

usr.bin/tftp/main.c