Differential D57071

tftp: Close files when we're done with them
ClosedPublic
Actions

Authored by des on May 18 2026, 9:34 PM.

Tags

None

Referenced Files

	F173861380: D57071.id178405.diff
	Mon, Sep 28, 11:16 PM

	F173857359: D57071.id178039.diff
	Mon, Sep 28, 10:42 PM

	Unknown Object (File)
	Fri, Sep 11, 2:32 AM

	Unknown Object (File)
	Thu, Sep 10, 9:13 AM

	Unknown Object (File)
	Tue, Sep 8, 8:27 AM

	Unknown Object (File)
	Sun, Sep 6, 12:52 PM

	Unknown Object (File)
	Sun, Sep 6, 12:46 PM

	Unknown Object (File)
	Sun, Sep 6, 12:34 AM

View All 80 Files

Subscribers

Details

Reviewers

Commits

rGddd16aef6b03: tftp: Close files when we're done with them
rG66a6b7e7e92f: tftp: Close files when we're done with them
rG29351335704e: tftp: Close files when we're done with them

Summary

Also, delete the file we created if receiving it failed.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.May 18 2026, 9:34 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 18 2026, 9:34 PM

des requested review of this revision.May 18 2026, 9:34 PM

Harbormaster completed remote builds in B73201: Diff 178039.May 18 2026, 9:34 PM

des added a parent revision: D57070: tftp: Simplify URI handling.May 18 2026, 9:34 PM

des added a child revision: D57072: tftp: Replace fgets with getline.

markj accepted this revision.May 19 2026, 1:05 PM

This revision is now accepted and ready to land.May 19 2026, 1:05 PM

des removed a child revision: D57072: tftp: Replace fgets with getline.May 19 2026, 9:58 PM

des added a child revision: D57105: tftp: Fix handling of port name or number.

Closed by commit rG29351335704e: tftp: Close files when we're done with them (authored by des). · Explain WhyMay 22 2026, 5:58 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG29351335704e: tftp: Close files when we're done with them.

des added a commit: rG66a6b7e7e92f: tftp: Close files when we're done with them.May 27 2026, 9:03 AM

des added a commit: rGddd16aef6b03: tftp: Close files when we're done with them.

Revision Contents
Changeset List

Path

Size

usr.bin/

tftp/

10 lines

Diff 178405

usr.bin/tftp/main.c

Loading...