tftp: Add test case with over-long URL
ClosedPublic
Actions

Authored by des on Mon, May 18, 9:34 PM.

Details

Reviewers

Commits

rG6764267a99db: tftp: Add test case with over-long URL
rG99cbf1f6d7d2: tftp: Add test case with over-long URL
rGb94689d036c5: tftp: Add test case with over-long URL

Summary

This adds a test case that passes a very long URL on the command line,
which would previously have resulted in a benign buffer overflow in
urihandling(), detectable only by compiling tftp with ASAN enabled.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Mon, May 18, 9:34 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, May 18, 9:34 PM

des requested review of this revision.Mon, May 18, 9:34 PM

Harbormaster completed remote builds in B73204: Diff 178042.Mon, May 18, 9:34 PM

des added a parent revision: D57073: tftp: Style cleanup.Mon, May 18, 9:34 PM

des added a child revision: D57075: tftpd: Add missing bounds checks.

markj accepted this revision.Tue, May 19, 1:15 PM

This revision is now accepted and ready to land.Tue, May 19, 1:15 PM

Closed by commit rGb94689d036c5: tftp: Add test case with over-long URL (authored by des). · Explain WhyFri, May 22, 5:58 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGb94689d036c5: tftp: Add test case with over-long URL.

des added a commit: rG99cbf1f6d7d2: tftp: Add test case with over-long URL.Wed, May 27, 9:04 AM

des added a commit: rG6764267a99db: tftp: Add test case with over-long URL.

Revision Contents
Changeset List

Path

Size

usr.bin/

tftp/

tests/

tftp_test.sh

24 lines

Diff 178409

View Options

usr.bin/tftp/tests/tftp_test.sh

tftp: Add test case with over-long URLClosedPublicActions