Differential D57105

tftp: Fix handling of port name or number
ClosedPublic
Actions

Authored by des on Tue, May 19, 9:58 PM.

Details

Reviewers

markj

Commits

rG47e4571df158: tftp: Fix handling of port name or number

Summary

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Tue, May 19, 9:58 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, May 19, 9:58 PM

des requested review of this revision.Tue, May 19, 9:58 PM

Harbormaster completed remote builds in B73245: Diff 178143.Tue, May 19, 9:58 PM

des added a child revision: D57072: tftp: Replace fgets with getline.Tue, May 19, 9:58 PM

des added a parent revision: D57071: tftp: Close files when we're done with them.

des mentioned this in D57072: tftp: Replace fgets with getline.

markj added inline comments.Wed, May 20, 1:35 PM

usr.bin/tftp/tftp.c
85	recvfile() has the same code.

recvfile

Harbormaster completed remote builds in B73306: Diff 178305.Thu, May 21, 9:42 AM

des marked an inline comment as done.Thu, May 21, 9:42 AM

markj accepted this revision.Thu, May 21, 2:17 PM

This revision is now accepted and ready to land.Thu, May 21, 2:17 PM

Closed by commit rG47e4571df158: tftp: Fix handling of port name or number (authored by des). · Explain WhyFri, May 22, 5:58 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG47e4571df158: tftp: Fix handling of port name or number.

Revision Contents
Changeset List

Path

Size

usr.bin/

tftp/

main.c

7 lines

tftp.c

40 lines

Diff 178406

View Options

usr.bin/tftp/main.c