tmpfs: Overhaul option handling on remount
ClosedPublic
Actions

Authored by des on Sun, May 17, 1:00 PM.

Details

Reviewers

kib
mjg

Commits

rG1cfc208a07b6: tmpfs: Overhaul option handling on remount

Summary

On remount, we must accept all the same options as on initial mount.
For parameters which we're unable to modify on the fly, fail only if
the new value is different from the existing one.

PR: 295096
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73184
Build 70067: arc lint + arc unit

Event Timeline

des created this revision.Sun, May 17, 1:00 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, May 17, 1:00 PM

des requested review of this revision.Sun, May 17, 1:00 PM

Harbormaster completed remote builds in B73159: Diff 177962.Sun, May 17, 1:00 PM

Please change the title from 'Overhaul remount handling' to 'Overhaul remount options handling'.
Quite non-trivial part of the remount handling for tmpfs is rw->ro remount, and from the title I thought that you rewrote that.

sys/fs/tmpfs/tmpfs_vfsops.c
338–339	Please put the assignment on the separate line.
361	Why ignoring nodes_max set to 0? Effectively the setting to 0 is allowed but ignored. Sam question for other cases below.

des marked an inline comment as done.Mon, May 18, 1:16 PM

des added inline comments.

sys/fs/tmpfs/tmpfs_vfsops.c
361	If the original mount command had `inodes=0`, the actual value will not be 0 and the comparison will fail if the remount command also includes `inodes=0`.