Page MenuHomeFreeBSD
Differential D56965

rtnetlink: Check for allocation failure in _nl_store_ifp_cookie()
Needs ReviewPublic
Actions

Authored by pouria on Tue, May 12, 12:40 PM.
Tags
None
Referenced Files
F157429140: D56965.diff
Thu, May 21, 8:48 AM
Unknown Object (File)
Tue, May 19, 9:38 PM
Unknown Object (File)
Tue, May 19, 6:01 AM
Unknown Object (File)
Tue, May 19, 5:59 AM
Unknown Object (File)
Mon, May 18, 11:41 PM
Unknown Object (File)
Mon, May 18, 9:02 PM
Unknown Object (File)
Mon, May 18, 9:02 PM
Unknown Object (File)
Mon, May 18, 9:02 PM
View All 100 Files
Subscribers
imp

Details

Reviewers
markj
glebius
melifaro
Group Reviewers
network
Summary

Almost impossible to happen, but if it does, just report nothing.

MFC after: 3 days

Test Plan

Follow up D56954

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 73013
Build 69896: arc lint + arc unit

Event Timeline

pouria created this revision.Tue, May 12, 12:40 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, May 12, 12:40 PM
pouria requested review of this revision.Tue, May 12, 12:40 PM
Harbormaster completed remote builds in B73013: Diff 177636.Tue, May 12, 12:40 PM
markj added a comment.Tue, May 12, 4:11 PM

Hmm, if we think it's impossible, then probably it's better to just assume nla_cookie != NULL rather than silently doing nothing? Otherwise we should probably report the error back to create_link(), no?

pouria added a comment.Tue, May 12, 9:33 PM
In D56965#1305148, @markj wrote:

Hmm, if we think it's impossible, then probably it's better to just assume nla_cookie != NULL rather than silently doing nothing? Otherwise we should probably report the error back to create_link(), no?

It's absolutely safe to assume nla_cookie != NULL.
Unless someone else touches this code and forgets about the null check.
We can leave it as is.

Revision Contents
Changeset List

PathSize
sys/
netlink/
route/
2 lines

Diff 177636

View Options

sys/netlink/route/iface_drivers.c

Loading...