Differential D56946

kernel: address executable stack warnings in amd64 gcc build
ClosedPublic
Actions

Authored by rlibby on May 11 2026, 4:14 PM.

Tags

None

Referenced Files

	F163212313: D56946.id177935.diff
	Tue, Jul 21, 2:42 AM

	F163177288: D56946.diff
	Mon, Jul 20, 6:37 PM

	Unknown Object (File)
	Sun, Jul 19, 3:58 PM

	Unknown Object (File)
	Sat, Jul 18, 9:17 AM

	Unknown Object (File)
	Wed, Jul 15, 7:21 AM

	Unknown Object (File)
	Wed, Jul 15, 7:21 AM

	Unknown Object (File)
	Wed, Jul 8, 9:07 PM

	Unknown Object (File)
	Sun, Jul 5, 6:40 AM

View All 37 Files

Subscribers

Details

Reviewers

imp
kib

Group Reviewers

Commits

rG755c1e039adf: kernel: address executable stack warnings in amd64 gcc build

Summary

Mark assembly files as not requiring executable stacks.

Bottom-up approach alternative to D56893.

Test Plan

make buildkernel && env MAKEOBJDIRPREFIX=/usr/obj/gcc14 CROSS_TOOLCHAIN=amd64-gcc14 make buildkernel

find /usr/obj/gcc14/gcc14/usr/src/freebsd/amd64.amd64 -name '*.meta' -exec grep --with-filename warning: {} \; | sort

Resolves this set of executable stack warnings:

./sys/GENERIC/kernel.full.meta:/usr/local/x86_64-unknown-freebsd16.0/bin/ld: warning: vmbus_vector.o: missing .note.GNU-stack section implies executable stack
./sys/GENERIC/modules/usr/src/freebsd/sys/modules/aesni/aesni.ko.full.meta:/usr/local/x86_64-unknown-freebsd16.0/bin/ld: warning: aeskeys_amd64.o: missing .note.GNU-stack section implies executable stack
./sys/GENERIC/modules/usr/src/freebsd/sys/modules/efirt/efirt.ko.full.meta:/usr/local/x86_64-unknown-freebsd16.0/bin/ld: warning: efirt_support.o: missing .note.GNU-stack section implies executable stack
./sys/GENERIC/modules/usr/src/freebsd/sys/modules/hyperv/vmbus/hv_vmbus.ko.full.meta:/usr/local/x86_64-unknown-freebsd16.0/bin/ld: warning: vmbus_vector.o: missing .note.GNU-stack section implies executable stack
./sys/GENERIC/modules/usr/src/freebsd/sys/modules/sgx/sgx.ko.full.meta:/usr/local/x86_64-unknown-freebsd16.0/bin/ld: warning: sgx_support.o: missing .note.GNU-stack section implies executable stack
./sys/GENERIC/modules/usr/src/freebsd/sys/modules/vmm/vmm.ko.full.meta:/usr/local/x86_64-unknown-freebsd16.0/bin/ld: warning: svm_support.o: missing .note.GNU-stack section implies executable stack

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72988
Build 69871: arc lint + arc unit

Event Timeline

rlibby created this revision.May 11 2026, 4:14 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMay 11 2026, 4:14 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

rlibby requested review of this revision.May 11 2026, 4:14 PM

Harbormaster completed remote builds in B72988: Diff 177593.May 11 2026, 4:14 PM

rlibby edited the summary of this revision. (Show Details)May 11 2026, 4:19 PM

rlibby edited the test plan for this revision. (Show Details)

rlibby added reviewers: imp, kib.

kib accepted this revision.May 13 2026, 12:40 AM

This revision is now accepted and ready to land.May 13 2026, 12:40 AM

Closed by commit rG755c1e039adf: kernel: address executable stack warnings in amd64 gcc build (authored by rlibby). · Explain WhyMay 16 2026, 8:25 PM

This revision was automatically updated to reflect the committed changes.

rlibby added a commit: rG755c1e039adf: kernel: address executable stack warnings in amd64 gcc build.

rlibby mentioned this in D56893: kern.mk: quiet bfd executable stack warnings.May 27 2026, 5:19 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

2 lines

efirt_support.S

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

ia32/

ia32_sigtramp.S

2 lines

sgx/

2 lines

vmm/

amd/

2 lines

intel/

2 lines

crypto/

aesni/

aeskeys_amd64.S

2 lines

dev/

hyperv/

vmbus/

amd64/

2 lines

tools/

2 lines

Diff 177593

sys/amd64/amd64/cpu_switch.S

Loading...

sys/amd64/amd64/efirt_support.S

Loading...

sys/amd64/amd64/exception.S

Loading...

sys/amd64/amd64/kexec_tramp.S

Loading...

sys/amd64/amd64/locore.S

Loading...

sys/amd64/amd64/mpboot.S

Loading...

sys/amd64/amd64/support.S

Loading...

sys/amd64/amd64/xen-locore.S

Loading...

sys/amd64/ia32/ia32_sigtramp.S

Loading...

sys/amd64/sgx/sgx_support.S

Loading...

sys/amd64/vmm/amd/svm_support.S

Loading...

sys/amd64/vmm/intel/vmx_support.S

Loading...

sys/crypto/aesni/aeskeys_amd64.S

Loading...

sys/dev/hyperv/vmbus/amd64/vmbus_vector.S

Loading...

sys/tools/vdso_wrap.S

Loading...